Skip to content

Publish nightly-<sha> tags and record the image's Node.js commit - #32

Open
Ethan-Arrowood wants to merge 1 commit into
mainfrom
image-commit-tag
Open

Ethan-Arrowood wants to merge 1 commit into
mainfrom
image-commit-tag

Conversation

@Ethan-Arrowood

Copy link
Copy Markdown
Contributor

This change updates the workflows to resolve the nodejs/node commit once per run so every platform builds the same thing. Each platform also pushes nightly-<sha>-linux-<arch>, and the merge step combines those into an immutable nightly-<sha> and nightly tags. Merging from the per-commit tags keeps overlapping runs from mixing commits in nightly. Single-platform manual runs only update nightly, since the other platform has no image for that commit.

Finally, the image records the commit in /home/developer/nodejs/node-commit (outside the checkout contributors mount over) and in the org.nodejs.node.commit label. This will be important for future improvements that need to know the commit used for the given build.

Refs: nodejs/node#67440

AI-assisted (Claude Opus 5.5, my setup). The words are my own, per the Human Voice policy.

This change updates the workflows to resolve the nodejs/node commit
once per run so every platform builds the same thing. Each platform
also pushes nightly-<sha>-linux-<arch>, and the merge step combines
those into an immutable nightly-<sha> and nightly tags. Merging
from the per-commit tags keeps overlapping runs from mixing commits
in nightly. Single-platform manual runs only update nightly, since
the other platform has no image for that commit.

Finally, the image records the commit in /home/developer/nodejs/node-commit
(outside the checkout contributors mount over) and in the org.nodejs.node.commit
label. This will be important for future improvements that need to know the
commit used for the given build.

Refs: nodejs/node#67440

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant