Repository navigation
Publish nightly-<sha> tags and record the image's Node.js commit - #32
Open
Ethan-Arrowood wants to merge 1 commit into
Open
Ethan-Arrowood wants to merge 1 commit into
Ethan-Arrowood wants to merge 1 commit into
Conversation
This change updates the workflows to resolve the nodejs/node commit once per run so every platform builds the same thing. Each platform also pushes nightly-<sha>-linux-<arch>, and the merge step combines those into an immutable nightly-<sha> and nightly tags. Merging from the per-commit tags keeps overlapping runs from mixing commits in nightly. Single-platform manual runs only update nightly, since the other platform has no image for that commit. Finally, the image records the commit in /home/developer/nodejs/node-commit (outside the checkout contributors mount over) and in the org.nodejs.node.commit label. This will be important for future improvements that need to know the commit used for the given build. Refs: nodejs/node#67440 Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
3 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the workflows to resolve the nodejs/node commit once per run so every platform builds the same thing. Each platform also pushes
nightly-<sha>-linux-<arch>, and the merge step combines those into an immutablenightly-<sha>andnightlytags. Merging from the per-commit tags keeps overlapping runs from mixing commits innightly. Single-platform manual runs only updatenightly, since the other platform has no image for that commit.Finally, the image records the commit in
/home/developer/nodejs/node-commit(outside the checkout contributors mount over) and in theorg.nodejs.node.commitlabel. This will be important for future improvements that need to know the commit used for the given build.Refs: nodejs/node#67440
AI-assisted (Claude Opus 5.5, my setup). The words are my own, per the Human Voice policy.