Skip to content

Add building by specific commit SHA - #31

Merged
Ethan-Arrowood merged 5 commits into
mainfrom
node-daily-dispatch
Nov 18, 2026
Merged

Ethan-Arrowood merged 5 commits into
mainfrom
node-daily-dispatch

Conversation

@Ethan-Arrowood

@Ethan-Arrowood Ethan-Arrowood commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

The core change is the Dockerfile and clone.sh now respect a NODE_REF value for building by the specified commit SHA

When not specified, it defaults to the head commit of the main branch of nodejs/node.

But the main intent for this feature is so that the nodejs/node repo can use repository_dispatch to automatically trigger new builds (with a specific commit hash) after successfully executing its own daily build workflow.

This change also merges the build workflows into one file to simplify things. It switches actions to using hashes for versions too (may want to consider installing a dep updater in this repo eventually).

Finally, I added some details to the README.md too.

I will be opening a PR on nodejs/node too shortly adding the repository_dispatch call to the daily build workflow. Once these are both approved I'll have to update the nodejs-github-bot to have write access on nodejs/devcontainer.

AI-assisted (Claude Opus 5.5, my setup). The words are my own, per the Human Voice policy.

The core change is the Dockerfile and clone.sh now respect a `NODE_REF` value for building by the specified commit SHA

When not specified, it defaults to the head commit of the main branch of `nodejs/node`.

But the main intent for this feature is so that the `nodejs/node` repo can use `repository_dispatch` to automatically
trigger new builds (with a specific commit hash) after successfully executing its own daily build workflow.

Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
Ethan-Arrowood added a commit to Ethan-Arrowood/node that referenced this pull request Oct 31, 2026
Sends a node-daily event to the nodejs/devcontainer repo to trigger
a new devcontainer build upon a successful daily build. It shares
the specific associated commit so the exact devcontainer is built.

Requires: nodejs/devcontainer#31

Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
@Ethan-Arrowood

Copy link
Copy Markdown
Contributor Author

Related to: nodejs/node#67153

@Ethan-Arrowood

Copy link
Copy Markdown
Contributor Author

I've also already created the new nightly-build-failure label so its ready to go as soon as this lands. If for some reason we don't want this or need to make changes I'll adjust that label too.

@inoway46 inoway46 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! One non-blocking suggestion for an edge case: since each run updates the same tags, overlapping runs could result in nightly containing arm64 and amd64 images built from different commits.

With daily builds normally running once a day, overlap seems unlikely. However, there are also weekly and manual triggers, so passing the image digests produced by each build to the merge workflow, instead of using the shared tags, would handle this case while preserving concurrent builds. This could be a follow-up PR.

Comment thread .github/workflows/docker-build.yml Resolved
Comment thread .github/workflows/docker-build.yml Resolved
Comment thread .github/workflows/docker-build.yml Resolved
Comment thread .github/workflows/docker-build.yml Resolved
Comment thread .github/workflows/docker-build.yml Resolved
Comment thread scripts/clone.sh Outdated
(
cd /home/developer/nodejs/node
git init --initial-branch=main
git remote add --track main origin https://github.com/nodejs/node.git

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add a origin remote when there's already an upstream pointing to the same URL? I don't think it's a good idea, origin should stay undefined, users can set it point to their fork

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed; fixing now.

Comment thread Dockerfile Resolved
Comment thread README.md Resolved
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Nov 18, 2026
Sends a node-daily event to the nodejs/devcontainer repo to trigger
a new devcontainer build upon a successful daily build. It shares
the specific associated commit so the exact devcontainer is built.

Requires: nodejs/devcontainer#31

Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: #67153
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Comment thread .github/workflows/docker-build.yml Resolved
- name: Keep the scheduled trigger enabled
run: gh api -X PUT "repos/${GITHUB_REPOSITORY}/actions/workflows/docker-build.yml/enable"
env:
GH_TOKEN: ${{ github.token }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does github.token have access to do this? I know may workflow actions need a PAT

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will:

Once these are both approved I'll have to update the nodejs-github-bot to have write access on nodejs/devcontainer.

Co-authored-by: Aviv Keller <me@aviv.sh>
@Ethan-Arrowood
Ethan-Arrowood merged commit cd1e392 into main Nov 18, 2026
@Ethan-Arrowood
Ethan-Arrowood deleted the node-daily-dispatch branch November 18, 2026 20:03
aduh95 pushed a commit to nodejs/node that referenced this pull request Nov 19, 2026
Sends a node-daily event to the nodejs/devcontainer repo to trigger
a new devcontainer build upon a successful daily build. It shares
the specific associated commit so the exact devcontainer is built.

Requires: nodejs/devcontainer#31

Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: #67153
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants