Skip to content

Add the CITGM environment variable for Babel - #1213

Merged
joyeecheung merged 1 commit into
nodejs:mainfrom
liuxingbaoyu:env-CITGM
Oct 23, 2026
Merged

joyeecheung merged 1 commit into
nodejs:mainfrom
liuxingbaoyu:env-CITGM

Conversation

@liuxingbaoyu

@liuxingbaoyu liuxingbaoyu commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Relates to #1194

Checklist
  • contribution guidelines followed
    here

@MikeMcC399

This comment was marked as resolved.

@nicolo-ribaudo

nicolo-ribaudo commented Oct 23, 2026 •

Copy link
Copy Markdown

@MikeMcC399 Babel already respects this env variable (babel/babel#18379). Is there anything to do other than what's in this PR to fix the issue? Do we need to cut a Babel release with that change, or is it enough for it to be on main?

@MikeMcC399

Copy link
Copy Markdown
Contributor

https://github.com/liuxingbaoyu/citgm/blob/a7654d653bb1bf325803c1ae72cea2451548cf64/lib/lookup.json#L2-L9

does not have any head: true entry so it will always be working from @babel/core:latest

@nicolo-ribaudo

Copy link
Copy Markdown

Ok I'm doing a Babel release now

@nicolo-ribaudo

Copy link
Copy Markdown

Done

@MikeMcC399

Copy link
Copy Markdown
Contributor

That looks good! I tested on a non-Jenkins system: Ubuntu 26.04.1 LTS with Node.js 24.22.1 LTS:

git clone https://github.com/nodejs/citgm
cd citgm
git remote add liuxingbaoyu https://github.com/liuxingbaoyu/citgm
git fetch liuxingbaoyu env-CITGM  
git checkout liuxingbaoyu/env-CITGM --track
npm install
npm link
citgm @babel/core
$ citgm @babel/core
info: starting            | @babel/core         
info: lookup              | @babel/core         
info: lookup-found        | @babel/core         
info: @babel/core lookup-replace| https://github.com/babel/babel/archive/v8.0.9.tar.gz
info: @babel/core yarn:   | Downloading project: https://github.com/babel/babel/archive/v8.0.9.tar.gz
info: @babel/core npm:    | Project downloaded v8.0.9.tar.gz
info: @babel/core yarn:   | yarn install started
info: @babel/core yarn:   | yarn install successfully completed
info: @babel/core yarn:   | test suite started  
info: passing module(s)   |                     
info: module name:        | @babel/core         
info: version:            | 8.0.9               
info: done                | The smoke test has passed.
info: duration            | test duration: 116953ms

@MikeMcC399 MikeMcC399 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I don't have write access to this repo, so it still needs to be approved by one of the citgm members (or releasers) so it can be merged.

@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.11%. Comparing base (b4fce12) to head (a7654d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1213   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2127     2127           
  Misses         86       86           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung
joyeecheung merged commit 98ba854 into nodejs:main Oct 23, 2026
11 checks passed
@MikeMcC399

Copy link
Copy Markdown
Contributor

@joyeecheung

Unfortunately this was merged with the wrong commit message. It should have had lookup: in it. Sorry, I didn't notice when I approved.

That could be manually corrected when release-please puts together the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants