FIX: Re fix/add QTableWidget features#1044
Conversation
| InstanceMethod("columnCount", &QTableWidgetWrap::columnCount), | ||
| InstanceMethod("rowCount", &QTableWidgetWrap::rowCount), | ||
| InstanceMethod("setColumnCount", &QTableWidgetWrap::setColumnCount), | ||
| InstanceMethod("setRowCount", &QTableWidgetWrap::setRowCount), |
There was a problem hiding this comment.
Did we have a whole bunch of code in there which just was never hooked up to the nodejs wrapper?
There was a problem hiding this comment.
Yes, I added the 4 actual missing functions that everything got somehow removed, and then re-wired the 15 or so missing InstanceMethod that should have been tied to code that still existed in both the C/H & TS files -- but somehow lost the InstanceMethods. So that code was failing from the TS/JS side since they weren't actually wired up...
There was a problem hiding this comment.
I should probably also mention the existing code still works and was originally from one of my prior PR's. It was hooked up before the refactoring, as I've been using several of those functions with QT 5. I finally upgraded the library to the current version and found all the broken issues.
My program seems to now be working again with the changes I've made into this PR.
2 participants
Apparently several months back in PR #1018 - many things were accidentally broken in the QTableWidget class.
This PR fixes these issues so that the QTableWidget functions properly again..