Updated Remote Methods#32
Closed
smith-kyle wants to merge 1 commit intonodegit:masterfrom
smith-kyle:master
Closed
Updated Remote Methods#32smith-kyle wants to merge 1 commit intonodegit:masterfrom smith-kyle:master
smith-kyle wants to merge 1 commit intonodegit:masterfrom
smith-kyle:master
Conversation
From instance methods to class methods. Also added the appropriate method signatures
Collaborator
|
We should pull this in after 0.5 is released |
Member
|
Were these changes made manually? Keep in mind we generate the docs. |
Member
|
Closed via: #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved
remote.setUrlandremote.setPushurlto Class Methods ofNodeGit.Remoteand changed the method signatures to reflect the actual implementation.