Fixed example walk-history-for-file.js#847
Merged
johnhaley81 merged 1 commit intonodegit:masterfrom Jan 5, 2016
pevers:master
Merged
Fixed example walk-history-for-file.js#847johnhaley81 merged 1 commit intonodegit:masterfrom pevers:master
johnhaley81 merged 1 commit intonodegit:masterfrom
pevers:master
Conversation
Collaborator
|
Thanks for the PR @pevers! |
johnhaley81
added a commit
that referenced
this pull request
Jan 5, 2016
Fixed example walk-history-for-file.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The walk-history-for-file.js example was broken so I fixed it with some minor changes. The reason it broke is that
diff.patches()returns a promise and not an array that can be reduced. I made the example a little bit less efficient (checking for an already present commit) but I think it is a little bit more readable. The screenshot shows a comparison ofgit logand the example. Note that it is not a 1-1 mapping because git log is a little bit more intelligent.output of git log descriptor.jsoutput of walk-history-for-file.js