Revert "Merge pull request #615 from heavyk/thenify-bluebird"#649
Merged
Revert "Merge pull request #615 from heavyk/thenify-bluebird"#649
Conversation
Collaborator
|
Yeah, looks like there's a lot more to #615 than I thought. |
maxkorp
added a commit
that referenced
this pull request
Jul 22, 2015
Revert "Merge pull request #615 from heavyk/thenify-bluebird"
Collaborator
Author
|
Travis is having mac timeouts, but the tests are otherwise passing. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually provided a host of issues (e.g. callback compatability, uses evals, uses native promises and others). The switch to bluebird is still wanted, but that's gonna take a second attempt.