remove non-isolate FatalException#613
Merged
Merged
Conversation
The non-isolate version of node::FatalException() has been deprecated in io.js; more precisely, it's deprecated in node.js v0.12 as well but a bug in joyent/node prevents the deprecation warning from printing. We don't have to catch exceptions ourselves. Exceptions simply unwind the stack until they encounter a try/catch block is encountered or the fatal exception handler in the io.js or node.js run-time.
Member
|
I'm okay with this change. I don't really care to support Node 0.10 anyways. |
tbranyen
added a commit
that referenced
this pull request
Jun 23, 2015
remove non-isolate FatalException
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit message modified from bnoordhuis/node-unix-dgram@314858e
no tests fail. works the same for me.
though, I'm not sure how node-0.10 would work.
I think it'd be the same though - a fatal exception is a fatal exception.