Template proto functions #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
local isn't necessary here, require does this automatically.
Collaborator
Author
There was a problem hiding this comment.
Gotcha. I've just been adding it everywhere in the name of consistency. I was actually having issues with files not loading thinking it wasnt grabbing htem, but they were bing swallowed by the catch on line 59
Member
|
I noticed a lot of |
Collaborator
Author
|
Yeah No problem. A lot of them got added in the tests during the clone fiasco |
maxkorp
force-pushed
the
template-proto-functions
branch
from
5f01cb0 to
740453d
Compare
maxkorp
force-pushed
the
template-proto-functions
branch
from
740453d to
1906fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes functions that share typenames available under the type. Eg instead of Clone.clone, you can just call Clone, or Reset instead of Reset.reset, etc.
Also disables the ability to require specific files, requiring you to load nodegit proper.