git_create_tag doesn't have the correct descriptor #430

mattyclarkson · 2015-02-27T18:21:50Z

The following code doesn't work:

// Commit the bower.json file
.then(function() {
  return repository.createCommitOnHead(['bower.json'], identity, identity, 'release ' + version);
})

// Tag the new commit
.then(function(oid) {
  return nodegit.Commit.lookup(repository, oid);
})
.then(function(commit) {
  return nodegit.Tag.create(null, repository, version, commit, identity, 'version ' + version, 0);
})

This is because the git_create_tag needs to have the following descriptor:

"git_tag_create": {
  "isAsync": true,
  "args": {
    "oid": {
    "isReturn": true,
    "isSelf": false,
    "shouldAlloc": true
  },
  "return": {
    "cppClassName": "Number",
    "jsClassName": "Number",
    "isErrorCode": true
  }
},

maxkorp · 2015-02-26T20:10:15Z

A note, should be able to skip the args/return with the isAsync set, at least, i'd try it without first, then add those if necessary.

mattyclarkson · 2015-02-27T18:28:14Z

Ow. it failed tests 😢 will look through the logs.

mattyclarkson · 2015-02-27T18:30:12Z

test/tests/tag.js

I don't really like that this test bundles both the creation and deletion together into a single test but if the tag isn't cleaned up the tests aren't repeatable.

johnhaley81 · 2015-02-27T18:31:09Z

Looks like it failed linting. Try running npm test to see the linter errors.

mattyclarkson · 2015-02-27T18:45:57Z

huh, the linting checks on appveyor are moaning about Promise being a bad name. but that is used across lots of the test files. Is that something I should fix up across all the files? Not sure why that didn't show up on my box.

mattyclarkson · 2015-02-27T18:46:29Z

Oh, I didn't run jshint lib test/tests examples lifecycleScripts

tbranyen · 2015-02-27T19:14:35Z

Ah my mistake, can you force push a fix that doesn't use camelCase, it's all lower case per:

http://jshint.com/docs/options/#futurehostile

mattyclarkson · 2015-02-27T19:38:47Z

Yay! 😃

johnhaley81 · 2015-02-27T19:40:28Z

👍

The `git_tag_create*` functions expect there to be a Oid pointer as the first parameter.

I'm not sure of how this should be handled at the moment. It will need a similar descriptor as `git_tag_create` but maybe extra data defining `buffer`.

A good convenience function for deleting a tag

This allows a user to easily create an annotated tag in a repository: ``` repository.createTag(oid, '0.0.0', 'version 0.0.0') .then(function(tag) { // The new tag is returned }); ```

This allows new tags to be created and tested

This is a simple function that can create a new lightweight tag in a repository. The same can be acheived by creating a new reference in `/refs/tags/` but this performs libgit2 validation of tag names. ``` return repository.createLightweightTag(oid, 'foobar') .then(function(tag) { // The new tag is returned }); ```

This flag fixes up the fact that we are polyfilling `Promise`: ``` var Promise = require('nodegit-promise'); ```

johnhaley81 · 2015-02-27T21:26:35Z

Manually merging this

johnhaley81 · 2015-02-27T21:29:31Z

Manually merged via 094f240

maxkorp · 2015-02-27T21:37:43Z

Awesome work @mattyclarkson

mattyclarkson · 2015-03-02T09:23:53Z

@johnhaley81, sorry I didn't merge this on friday the build failed on appveyor and I had to leave for a weekend away! Thanks for merging it in manually.

johnhaley81 · 2015-03-02T14:02:38Z

No worries :)

On Mon, Mar 2, 2015, 2:23 AM Matt Clarkson notifications@github.com wrote:

@johnhaley81 https://github.com/johnhaley81, sorry I didn't merge this
on friday the build failed on appveyor and I had to leave for a weekend
away! Thanks for merging it in manually.

—
Reply to this email directly or view it on GitHub
#430 (comment).

johnhaley81 added this to the 0.3.0 milestone Feb 26, 2015

johnhaley81 added the Bug label Feb 26, 2015

mattyclarkson reviewed Feb 27, 2015
View reviewed changes

mattyclarkson force-pushed the master branch from 999d038 to c46898c Compare February 27, 2015 18:37

mattyclarkson force-pushed the master branch 2 times, most recently from 90725d0 to d7c9e04 Compare February 27, 2015 19:26

mattyclarkson force-pushed the master branch from 7574215 to d7c9e04 Compare February 27, 2015 20:11

mattyclarkson added 10 commits February 27, 2015 20:15

Added git_tag_create* descriptors

8aefba6

The `git_tag_create*` functions expect there to be a Oid pointer as the first parameter.

Added git_tag_delete descriptor

0e10205

Ignore git_tag_create_frombuffer

91b8b0c

I'm not sure of how this should be handled at the moment. It will need a similar descriptor as `git_tag_create` but maybe extra data defining `buffer`.

repository.deleteTagByName API

24e06c6

A good convenience function for deleting a tag

Added Repository.createTag API

4369544

This allows a user to easily create an annotated tag in a repository: ``` repository.createTag(oid, '0.0.0', 'version 0.0.0') .then(function(tag) { // The new tag is returned }); ```

Allow overriding the tag name in the testTag function

b544898

This allows new tags to be created and tested

Unit tests for Repository.createTag

189854f

Unit testing for repository.createLightweightTag

cb5ceec

Added futureHostile to .jshintrc

54c8364

This flag fixes up the fact that we are polyfilling `Promise`: ``` var Promise = require('nodegit-promise'); ```

mattyclarkson force-pushed the master branch from d7c9e04 to 54c8364 Compare February 27, 2015 20:15

johnhaley81 closed this Feb 27, 2015

snyk-bot mentioned this pull request Mar 18, 2020

[Snyk] Upgrade node-pre-gyp from 0.6.39 to 0.14.0 contentascode/nodegit#1

Open

git_create_tag doesn't have the correct descriptor #430

git_create_tag doesn't have the correct descriptor #430

Uh oh!

Conversation

mattyclarkson commented Feb 27, 2015

Uh oh!

maxkorp commented Feb 26, 2015

Uh oh!

mattyclarkson commented Feb 27, 2015

Uh oh!

mattyclarkson Feb 27, 2015

Choose a reason for hiding this comment

Uh oh!

johnhaley81 commented Feb 27, 2015

Uh oh!

mattyclarkson commented Feb 27, 2015

Uh oh!

mattyclarkson commented Feb 27, 2015

Uh oh!

tbranyen commented Feb 27, 2015

Uh oh!

mattyclarkson commented Feb 27, 2015

Uh oh!

johnhaley81 commented Feb 27, 2015

Uh oh!

johnhaley81 commented Feb 27, 2015

Uh oh!

johnhaley81 commented Feb 27, 2015

Uh oh!

maxkorp commented Feb 27, 2015

Uh oh!

mattyclarkson commented Mar 2, 2015

Uh oh!

johnhaley81 commented Mar 2, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants