Attempt to fix Windows file locking bug #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbranyen
force-pushed
the
fix-file-lock
branch
3 times, most recently
from
b821ff9 to
0e93e48
Compare
Closed
tbranyen
force-pushed
the
fix-file-lock
branch
from
9bf6559 to
8c7ac59
Compare
I ensured that every time we work with a repository it is attached under `test.repository`. This makes our `afterEach` much more consistent and concise. I changed the `free` code to only occur under Windows, where file locking is still a thing.
johnhaley81
force-pushed
the
fix-file-lock
branch
from
8c7ac59 to
f6c9582
Compare
Added a new `beforeEach` to ensure repositories are cleaned in clone, not sure why this is required.
tbranyen
force-pushed
the
fix-file-lock
branch
from
f6c9582 to
342b6e6
Compare
Member
Author
|
I'm merging this since the tests pass and we fixed the major issues around the file locking. We are still getting an occasional segfault that we'll need to address in a separate PR. |
tbranyen
added a commit
that referenced
this pull request
Feb 26, 2015
Attempt to fix Windows file locking bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.