Fixes segfault issue recorded in #406 #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@lange if you could give this a branch a shot, I believe it'll address your issue. |
tbranyen
force-pushed
the
fix-credentials-segfault
branch
from
c6c66a8 to
f719bbe
Compare
Collaborator
|
👍 nice going tbranyen |
johnhaley81
force-pushed
the
fix-credentials-segfault
branch
from
c0b7fad to
d2ec5be
Compare
If you attempt to clone a private repository without passing along a username, `NULL` will make `NanNew` very upset.
A segfault was occuring when passing null values to `NanNew`, this patch will the bug for `const char *` and `unsigned int` C types. We'll definitely need to add more in the future.
This allowed us to reuse folders. I also fixed the tests to allow use a certificate check callback (where required).
johnhaley81
force-pushed
the
fix-credentials-segfault
branch
from
d2ec5be to
ad310b3
Compare
Collaborator
johnhaley81
added a commit
that referenced
this pull request
Feb 24, 2015
Fixes segfault issue recorded in #406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A segfault was occuring when passing null values to
NanNew, this patchwill the bug for
const char *andunsigned intC types. We'lldefinitely need to add more in the future.