WIP: Refactor publishing #350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkorp
force-pushed
the
refactor-publishing
branch
from
e6c5819 to
7258070
Compare
Collaborator
Author
|
So I'm trying to figure out why this fails on linux 10, something with content type headers not being set... |
Collaborator
|
👍, but bump the minor version number when you release it. If it introduces the smallest bug, it will trouble people that depends on ~0.2.4. I suggest keeping this new 0.3 release in a new branch, just to simplify life for newcomers to the project, and merge when it is all done. |
Collaborator
Author
|
I'm fine pushing it to an 0.3.0. Might be time for that bump soon anyways with the libgit changes from upstream. |
maxkorp
force-pushed
the
refactor-publishing
branch
5 times, most recently
from
2dfad62 to
6188842
Compare
Collaborator
Author
|
During the refactor a version check got missed, which usually caused a different version of http_parser to get pulled in for v10. That wasnt happening, causing a mismatch. |
maxkorp
force-pushed
the
refactor-publishing
branch
3 times, most recently
from
cc3e106 to
d4bbb04
Compare
includes cleaning of npm registry based installs and a new debug build
maxkorp
force-pushed
the
refactor-publishing
branch
from
d4bbb04 to
cad078e
Compare
Collaborator
Author
|
Making a new PR for the 0.3 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I've done quite a bit here.
npm run buildDebug