Skip to content

Make remote#download async #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbranyen merged 5 commits into from
Feb 7, 2015
Merged

Make remote#download async #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a326f1
Make remote#download async
tbranyen Dec 9, 2014
2094b51
Minor test tweak
tbranyen Jan 12, 2015
34b72a9
Change test slightly
tbranyen Jan 29, 2015
3a4060d
expose actual issue with remote.connect
maxkorp Jan 30, 2015
3e1daae
Attempting to fix cert errors with os x
tbranyen Feb 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions generate/input/descriptor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,6 +1115,17 @@
"remote": {
"cType": "git_remote",
"functions": {
"git_remote_connect": {
"return": {
"isErrorCode": true
}
},
"git_remote_download": {
"isAsync": true,
"return": {
"isErrorCode": true
}
},
"git_remote_default_branch": {
"ignore": true
},
Expand Down
13 changes: 5 additions & 8 deletions test/tests/remote.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,12 @@ describe("Remote", function() {
it("can download from a remote", function() {
var repo = this.repository;

return Remote.load(repo, "origin")
.then(function(remote) {
return repo.getRemote("origin").then(function(remote) {
remote.checkCert(0);

remote.connect(NodeGit.Enums.DIRECTION.FETCH);

return remote.download();
})
.then(function() {
assert(true);
}, function() {
assert(false);
});
});

Expand All @@ -114,7 +111,7 @@ describe("Remote", function() {
it("can fetch from all remotes", function() {
// Set a reasonable timeout here for the fetchAll test
this.timeout(15000);

return this.repository.fetchAll({
credentials: function(url, userName) {
return NodeGit.Cred.sshKeyFromAgent(userName);
Expand Down