Skip to content

Fix repo init ext #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxkorp merged 2 commits into from
Dec 5, 2014
Merged

Fix repo init ext #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e35db07
make Repository.initExt normalize options
maxkorp Dec 5, 2014
ea2a390
add test for initExt
maxkorp Dec 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ var Revwalk = require("./revwalk");
var Commit = require("./commit");
var Remote = require("./remote");
var Promise = require("nodegit-promise");
var normalizeOptions = require("./util/normalize_options");

var TreeBuilder = NodeGit.Treebuilder;
var Repository = NodeGit.Repository;
Expand Down Expand Up @@ -641,4 +642,12 @@ Repository.prototype.mergeBranches = function(to, from, signature) {
});
};

// Override Repository.initExt to normalize initoptions
var initExt = Repository.initExt;
Repository.initExt = function(repo_path, opts) {
opts = normalizeOptions(opts, NodeGit.RepositoryInitOptions);
return initExt(repo_path, opts);
};


module.exports = Repository;
10 changes: 10 additions & 0 deletions test/tests/repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
var assert = require("assert");
var path = require("path");
var promisify = require("promisify-node");
var fse = promisify(require("fs-extra"));

describe("Repository", function() {
var reposPath = path.resolve("test/repos/workdir/.git");
Expand Down Expand Up @@ -41,6 +43,14 @@ describe("Repository", function() {
});
});

it("can utilize repository init options", function() {
return fse.remove(newRepo).then(function() {
return Repository.initExt(newRepo, {
flags: Repository.INIT_FLAG.MKPATH
});
});
});

it("can read the index", function() {
return this.repository.index().then(function(index) {
assert.ok(index instanceof Index);
Expand Down