Fix 313 generate scripts #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Going to wait for 310 to finish before we merge this in. |
Collaborator
|
Hey, now that 310 is merged in, if you can rebase this up on top of master we can go ahead and merge it in. |
graycodes
force-pushed
the
fix-313-generate-scripts
branch
from
3b4d950 to
3006ad2
Compare
Contributor
Author
|
Rebased against master. Waiting for build. |
Collaborator
|
I'm calling this passing and merging it in. See #316 |
Collaborator
|
Thanks for the help @xinumbralis!! |
Contributor
Author
|
No worries at all! I'll get started on the tests before long. |
Collaborator
|
This fixes #313 |
Collaborator
|
Very much appreciated @xinumbralis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the contributing file to reflect script changes.
Updated each generate script to pass an IIFE to module.exports.
Updated generate/index.js to account for the above.