Update windows 2016 CI to 2019 #1897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianmesa-gitkraken
changed the title
To update Windows box we need to upgrade node-gyp, so we need python 3.6 in ubuntu 16.04, but last version is 3.5. This is the reason Python 3.6 is build from source.
julianmesa-gitkraken
force-pushed
the
update-windows-ci-actions
branch
from
8256f72 to
c303953
Compare
ianhattendorf
requested changes
Mar 16, 2022
Member
ianhattendorf
left a comment
ianhattendorf
left a comment
There was a problem hiding this comment.
- Make sure to commit your
package-lock.jsonchanges - There's a breaking change in @mapbox/node-pre-gyp v1.0.0 we need to handle, see https://github.com/mapbox/node-pre-gyp/blob/master/CHANGELOG.md (related: #1866)
No longer supporting node_pre_gyp_accessKeyId & node_pre_gyp_secretAccessKey, use AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY instead to authenticate against s3
julianmesa-gitkraken
force-pushed
the
update-windows-ci-actions
branch
from
b851df4 to
0f897b2
Compare
Contributor
Author
Done in commit: "Update node-pre-gyp to use @mapbox/node-pre-gyp" |
ianhattendorf
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To update Windows box we need to upgrade node-gyp, so we need python 3.6 in ubuntu 16.04, but last version is 3.5. This is the reason Python 3.6 is build from source.