Skip to content

Update Github Actions for node 16 #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianhattendorf merged 1 commit into from
Mar 4, 2022
Merged

Update Github Actions for node 16 #1896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ jobs:
name: "Linux Tests"
strategy:
matrix:
node: [12, 14]
node: [12, 14, 16]
runs-on: ubuntu-latest
container: ubuntu:16.04
steps:
- name: Install Dependencies for Ubuntu
# git >= 2.18 required for actions/checkout git support
run: apt update && apt install -y software-properties-common && add-apt-repository -y ppa:git-core/ppa && apt update && apt install -y git build-essential clang python3 libssl-dev libkrb5-dev libc++-dev
run: apt-get update && apt-get install -y software-properties-common && add-apt-repository -y ppa:git-core/ppa && apt-get update && apt-get install -y git build-essential clang python3 libssl-dev libkrb5-dev libc++-dev
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true

Expand Down Expand Up @@ -52,7 +52,10 @@ jobs:
npm_config_clang: 1
GYP_DEFINES: use_obsolete_asm=true
# There is a race condition in node/generate that needs to be fixed
# Node 16 changed the logic it uses to select it's UID which means to make node run as root and not 1001, we need to chwon the current directory. More Details:
# https://stackoverflow.com/questions/70298238/getting-eaccess-when-running-npm-8-as-root
run: |
chown root.root -R .
npm set unsafe-perm true
node utils/retry npm install

Expand All @@ -79,7 +82,7 @@ jobs:
name: "macOS Tests"
strategy:
matrix:
node: [12, 14]
node: [12, 14, 16]
runs-on: macOS-10.15
# This is mostly the same as the Linux steps, waiting for anchor support
# https://github.com/actions/runner/issues/1182
Expand Down Expand Up @@ -137,7 +140,7 @@ jobs:
name: Windows Tests
strategy:
matrix:
node: [12, 14]
node: [12, 14, 16]
arch: [x86, x64]
runs-on: windows-2016
steps:
Expand Down
Empty file modified lifecycleScripts/install.js
100644 → 100755
View file
Open in desktop
Empty file.
Empty file modified lifecycleScripts/preinstall.js
100644 → 100755
View file
Open in desktop
Empty file.