Skip to content

Refactor for context-awareness #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 40 commits into from
Oct 20, 2020
Merged

Refactor for context-awareness #1795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
7949764
Cleanup unused ifdefs
implausible Jul 31, 2020
33326b4
Guard initialization so that we only initialize our core libraries once
implausible Jul 31, 2020
5ad8682
Use NAN_MODULE_INIT and prevent worker_threads from booting library
implausible Jul 31, 2020
6167a10
Make LockMaster shareable across contexts
implausible Aug 3, 2020
a820ff4
Get rid of libuv in lock_master
implausible Aug 5, 2020
67d77d9
Get rid of unnecessary libuv in thread pool
implausible Aug 17, 2020
88711bf
Fix jshint
implausible Aug 18, 2020
deb1430
Rewrite thread pool for context awareness
implausible Aug 25, 2020
42e266e
Skeleton shutdown logic for thread pool and cancellation of work
implausible Aug 25, 2020
317f3a7
Complete implementation of libgit2 callback cancellation
implausible Aug 28, 2020
fa03769
Add HandleErrorCallback skeleton
ianhattendorf Aug 27, 2020
f259b6f
Add skeleton of manual templates
ianhattendorf Aug 27, 2020
50444d0
Fix Repository.discover description
ianhattendorf Aug 27, 2020
c0ff5e6
Cleanup additional baton members
ianhattendorf Aug 27, 2020
ce43d92
Call callback from HandleErrorCallback
ianhattendorf Aug 27, 2020
223bf7e
Don't call callback if AsyncWorker is cancelled
ianhattendorf Aug 28, 2020
af5585c
Cleanup HandleErrorCallback template
ianhattendorf Aug 28, 2020
610104b
Fill in skeleton HandleErrorCallbacks
ianhattendorf Aug 28, 2020
9a51900
Add missing HandleErrorCallbacks
ianhattendorf Aug 28, 2020
bed58a4
Value initialize batons
ianhattendorf Sep 1, 2020
74fe6e1
Use freeFunctionName to free returned args on error
ianhattendorf Sep 1, 2020
046a7ad
Value initialize manual template batons as well
ianhattendorf Sep 2, 2020
bf7b13f
Cleanup manual template batons
ianhattendorf Sep 2, 2020
e4a9092
Enable module from workers
ianhattendorf Sep 3, 2020
7f358d1
Test clone via worker thread
ianhattendorf Sep 3, 2020
7c50ce5
Allow nodegit to run via worker thread or web worker
ianhattendorf Sep 3, 2020
f82e10c
More reliable worker thread test
ianhattendorf Sep 3, 2020
8a5ee94
Remove duplicate locks
ianhattendorf Sep 8, 2020
aaa34ee
Verify context before running cppCallback
ianhattendorf Sep 10, 2020
69d9d4e
Stick to c++11 for a little bit longer
ianhattendorf Sep 11, 2020
ee1865c
Only test worker_threads if they are available
ianhattendorf Sep 11, 2020
a21efa6
Threadpool shutdown uv_close asynchronously
ianhattendorf Sep 11, 2020
130560b
Fix misc warnings
ianhattendorf Sep 11, 2020
9d5a42b
Test on node 14 only until backport of required node PR
ianhattendorf Sep 11, 2020
01765fb
Don't leak jsThreadCallbackAsync
ianhattendorf Sep 11, 2020
fb17372
Build a cleanup handle that can be deleted by last user
implausible Sep 12, 2020
7a7e1fa
Use a better data type for data on uv_async_t
implausible Sep 12, 2020
cb7cd26
Fix ordering issue on Windows
implausible Sep 14, 2020
85f55d4
Require 12.19.0+ or 14.10.0+ due to async cleanup
ianhattendorf Oct 19, 2020
08db6fc
Check for latest node version when running tests
ianhattendorf Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
name: "*nix Tests"
strategy:
matrix:
node: [10, 12, 14]
node: [12, 14]
os: [ubuntu-16.04, macOS-10.15]
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -35,6 +35,7 @@ jobs:
uses: actions/setup-node@master
with:
node-version: ${{ matrix.node }}
check-latest: true

- name: Install Dependencies for Ubuntu
if: startsWith(matrix.os, 'ubuntu')
Expand Down Expand Up @@ -72,7 +73,7 @@ jobs:
name: Windows Tests
strategy:
matrix:
node: [10, 12, 14]
node: [12, 14]
arch: [x86, x64]
runs-on: windows-2016
steps:
Expand All @@ -90,6 +91,7 @@ jobs:
uses: implausible/setup-node@feature/expose-architecture-override
with:
node-version: ${{ matrix.node }}
check-latest: true
node-arch: ${{ matrix.arch }}

- name: Install
Expand Down
Loading