Skip to content

Refactor for context-awareness #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
implausible merged 40 commits into from
Oct 20, 2020
Merged

Refactor for context-awareness #1795

implausible merged 40 commits into from
Oct 20, 2020

Conversation

@ianhattendorf
Copy link
Member

@ianhattendorf ianhattendorf commented Sep 11, 2020

TLDR:

  • worker_thread support!
  • Electron support when app.allowRendererProcessReuse=true

Fixes #1774

implausible and others added 30 commits August 25, 2020 15:01
@implausible
Cleanup unused ifdefs
7949764
@implausible
Guard initialization so that we only initialize our core libraries once
33326b4
@implausible
Use NAN_MODULE_INIT and prevent worker_threads from booting library
5ad8682 
Until node understands how to cleanup a native node module asynchronously, we cannot allow nodegit to operate in a worker thread or it will die on exit.

Other concerns... Process reuse in Electron may be a problem without async cleanup being a real thing.
@implausible
Make LockMaster shareable across contexts
6167a10
@implausible
Get rid of libuv in lock_master
a820ff4
@implausible
Get rid of unnecessary libuv in thread pool
67d77d9
@implausible
Fix jshint
88711bf
@implausible
Rewrite thread pool for context awareness
deb1430
@implausible
Skeleton shutdown logic for thread pool and cancellation of work
42e266e
@implausible
Complete implementation of libgit2 callback cancellation
317f3a7
@ianhattendorf
Add HandleErrorCallback skeleton
fa03769
@ianhattendorf
Add skeleton of manual templates
f259b6f
@ianhattendorf
Fix Repository.discover description
50444d0
@ianhattendorf
Cleanup additional baton members
c0ff5e6
@ianhattendorf
Call callback from HandleErrorCallback
ce43d92
@ianhattendorf
Don't call callback if AsyncWorker is cancelled
223bf7e 
We aren't allowed to call back to JavaScript in this case
@ianhattendorf
Cleanup HandleErrorCallback template
af5585c
@ianhattendorf
Fill in skeleton HandleErrorCallbacks
610104b
@ianhattendorf
Add missing HandleErrorCallbacks
9a51900
@ianhattendorf
Value initialize batons
bed58a4 
Ensure baton data members are value initialized (since batons are trivial types)
@ianhattendorf
Use freeFunctionName to free returned args on error
74fe6e1
@ianhattendorf
Value initialize manual template batons as well
046a7ad
@ianhattendorf
Cleanup manual template batons
bf7b13f
@ianhattendorf
Enable module from workers
e4a9092
@ianhattendorf
Test clone via worker thread
7f358d1
@ianhattendorf
Allow nodegit to run via worker thread or web worker
7c50ce5
@ianhattendorf
More reliable worker thread test
f82e10c
@ianhattendorf
Remove duplicate locks
8a5ee94 
We already lock in AcquireLocks
@ianhattendorf
Verify context before running cppCallback
aaa34ee
@ianhattendorf
Stick to c++11 for a little bit longer
69d9d4e 
RHEL 7 is still fairly popular and on GCC 4.8.x
@implausible implausible mentioned this pull request Sep 11, 2020
Open
@ianhattendorf
Threadpool shutdown uv_close asynchronously
a21efa6 
Windows fails to shutdown synchronously, so shutdown asynchronously. This is only supported by node 14.10+ currently. Should be backported to LTS releases shortly
@ianhattendorf
Fix misc warnings
130560b
@ianhattendorf
Test on node 14 only until backport of required node PR
9d5a42b 
PR: nodejs/node#34819
implausible
implausible reviewed Sep 11, 2020
View reviewed changes
implausible
implausible reviewed Sep 11, 2020
View reviewed changes
@implausible implausible mentioned this pull request Oct 6, 2020
Closed
@implausible
Copy link
Member

implausible commented Oct 19, 2020 •
edited
Loading

hooo weee...

@implausible implausible merged commit 5e04ffa into nodegit:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@implausible implausible implausible left review comments

Assignees

@implausible implausible

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make nodegit context-aware for compatibility with Electron 9 and beyond

2 participants

@ianhattendorf @implausible