Skip to content

Node 14 support #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrislloyd wants to merge 1 commit into from
Closed

Node 14 support #1779

chrislloyd wants to merge 1 commit into from

Conversation

@chrislloyd
Copy link

@chrislloyd chrislloyd commented Jul 7, 2020 •
edited
Loading

I'm seeing nodegit failing to install with Node 14 and was hoping to create a PR to produce a test case. It looks like CI is generally failing so that's a little difficult.

> node lifecycleScripts/preinstall.js && node lifecycleScripts/install.js

internal/modules/cjs/loader.js:1033
  throw err;
  ^

Error: Cannot find module '/root/workspace/bandit/node_modules/nodegit/lifecycleScripts/preinstall.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1030:15)
    at Function.Module._load (internal/modules/cjs/loader.js:899:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

@implausible
Copy link
Member

implausible commented Jul 28, 2020

Closed by #1785.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrislloyd @implausible