Optionally retrieve more data on commit walk #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcjsuen
reviewed
Sep 26, 2019
implausible
force-pushed
the
feature/commit-walk-commit-models
branch
2 times, most recently
from
ff67f6e to
796c589
Compare
implausible
force-pushed
the
feature/commit-walk-commit-models
branch
from
796c589 to
6ecd368
Compare
ianhattendorf
requested changes
Sep 26, 2019
Member
ianhattendorf
left a comment
ianhattendorf
left a comment
There was a problem hiding this comment.
Awesome. A few variables can be const and a few casts can be narrowed, but everything else looks good. Much faster than before.
ianhattendorf
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this exact routine in GitKraken every time we need to get commits from libgit2. Considering that
commit.getSignatureis async, we waste a ton of time in processing callbacks for our commits there. This will retrieve all of the data we need in bulk, and ship that back in a neater package.