Skip to content

Don't fail yarn installs when we can't find npm #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 1 commit into from
Mar 4, 2019
Merged

Don't fail yarn installs when we can't find npm #1644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions lifecycleScripts/preinstall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,22 @@ module.exports = function prepareForBuild() {
console.log("[nodegit] Running pre-install script");

return exec("npm -v")
.then(function(npmVersion) {
if (npmVersion.split(".")[0] < 3) {
console.log("[nodegit] npm@2 installed, pre-loading required packages");
return exec("npm install --ignore-scripts");
}
.then(
function(npmVersion) {
if (npmVersion.split(".")[0] < 3) {
console.log(
"[nodegit] npm@2 installed, pre-loading required packages"
);
return exec("npm install --ignore-scripts");
}

return Promise.resolve();
})
return Promise.resolve();
},
function() {
// We're installing via yarn, so don't
// care about compability with npm@2
}
)
.then(function() {
if (buildFlags.isGitRepo) {
var submodules = require(local("submodules"));
Expand Down