Skip to content

Output the item that was deprecated when giving deprecation notice #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 1 commit into from
Mar 4, 2019
+15 −9
Merged

Output the item that was deprecated when giving deprecation notice #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ Object.keys(NodeGit.Error.CODE).forEach((key) => {
Object.defineProperty(NodeGit.Error.CODE, `GITERR_${key}`, {
get: util.deprecate(
() => NodeGit.Error.CODE[key],
`Use NodeGit.Error.CODE.${key} instead.`
`Use NodeGit.Error.CODE.${key} instead of ` +
`NodeGit.Error.CODE.GETERR_${key}.`
)
});
});
12 changes: 8 additions & 4 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ Object.keys(NodeGit.Index.CAPABILITY).forEach((key) => {
Object.defineProperty(NodeGit.Index.CAP, key, {
get: util.deprecate(
() => NodeGit.Index.CAPABILITY[key],
`Use NodeGit.Index.CAPABILITY.${key} instead.`
`Use NodeGit.Index.CAPABILITY.${key} instead of ` +
`NodeGit.Index.CAP.${key}.`
)
});
});
Expand All @@ -50,13 +51,15 @@ NodeGit.Enums.INDXENTRY_FLAG = {};
Object.defineProperty(NodeGit.Enums.INDXENTRY_FLAG, "IDXENTRY_EXTENDED", {
get: util.deprecate(
() => NodeGit.Index.ENTRY_FLAG.ENTRY_EXTENDED,
"Use NodeGit.Index.ENTRY_FLAG.ENTRY_EXTENDED instead."
"Use NodeGit.Index.ENTRY_FLAG.ENTRY_EXTENDED instead of " +
"NodeGit.Enums.INDXENTRY_FLAG.IDXENTRY_EXTENDED."
)
});
Object.defineProperty(NodeGit.Enums.INDXENTRY_FLAG, "IDXENTRY_VALID", {
get: util.deprecate(
() => NodeGit.Index.ENTRY_FLAG.ENTRY_VALID,
"Use NodeGit.Index.ENTRY_FLAG.ENTRY_VALID instead."
"Use NodeGit.Index.ENTRY_FLAG.ENTRY_VALID instead of " +
"NodeGit.Enums.INDXENTRY_FLAG.IDXENTRY_VALID."
)
});

Expand All @@ -72,7 +75,8 @@ Object.keys(EXTENDED_FLAGS_MAP).forEach((key) => {
Object.defineProperty(NodeGit.Enums.IDXENTRY_EXTENDED_FLAG, key, {
get: util.deprecate(
() => NodeGit.Index.ENTRY_EXTENDED_FLAG[newKey],
`Use NodeGit.Index.ENTRY_EXTENDED_FLAG.${newKey} instead.`
`Use NodeGit.Index.ENTRY_EXTENDED_FLAG.${newKey} instead of ` +
`NodeGit.Enums.IDXENTRY_EXTENDED_FLAG.${key}.`
)
});
});
Expand Down
2 changes: 1 addition & 1 deletion lib/object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ Obj.prototype.isTree = function() {
Object.defineProperty(Obj.TYPE, "BAD", {
get: util.deprecate(
() => Obj.TYPE.INVALID,
"Use NodeGit.Object.TYPE.INVALID instead."
"Use NodeGit.Object.TYPE.INVALID instead of NodeGit.Object.TYPE.BAD."
)
});
7 changes: 4 additions & 3 deletions lib/reference.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,14 @@ Reference.updateTerminal = function (
Object.defineProperty(NodeGit.Reference.TYPE, "OID", {
get: util.deprecate(
() => NodeGit.Reference.TYPE.DIRECT,
"Use NodeGit.Reference.TYPE.DIRECT instead."
"Use NodeGit.Reference.TYPE.DIRECT instead of NodeGit.Reference.TYPE.OID."
)
});

Object.defineProperty(NodeGit.Reference.TYPE, "LISTALL", {
get: util.deprecate(
() => NodeGit.Reference.TYPE.ALL,
"Use NodeGit.Reference.TYPE.ALL instead."
"Use NodeGit.Reference.TYPE.ALL instead of NodeGit.Reference.TYPE.LISTALL."
)
});

Expand All @@ -206,7 +206,8 @@ Object.keys(NodeGit.Reference.FORMAT).forEach((key) => {
Object.defineProperty(NodeGit.Reference.NORMALIZE, `REF_FORMAT_${key}`, {
get: util.deprecate(
() => NodeGit.Reference.FORMAT[key],
`Use NodeGit.Reference.FORMAT.${key} instead.`
`Use NodeGit.Reference.FORMAT.${key} instead of ` +
`NodeGit.Reference.NORMALIZE.REF_FORMAT_${key}.`
)
});
});