Add support for building on IBM i (PASE) #1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implausible
requested changes
Feb 19, 2019
Member
implausible
left a comment
implausible
left a comment
There was a problem hiding this comment.
You shouldn't need to add utils/isBuildingForIBMi.js as the operation for detecting if we're on IBM i seems pretty straightforward. Here's how you could shorten this PR in that way.
Do you happen to know of any free CI tools we could use to test / build against this operating system?
implausible
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow nodegit to build in the IBM i operating system's PASE environment.
https://en.wikipedia.org/wiki/IBM_i