Fix non-existent / dangling refs cause Repository.prototype.createCommitWithSignature to fail#1624
Merged
implausible merged 5 commits intoFeb 8, 2019
Conversation
implausible
requested changes
Feb 8, 2019
implausible
left a comment
implausible
left a comment
Member
There was a problem hiding this comment.
Nice! Can you adjust the documentation in these 2 spots, please?
| } | ||
|
|
||
| return result; | ||
| return NodeGit.Signature.default(this) |
Member
There was a problem hiding this comment.
Can you update the JSDoc above this to be @async
| .catch(() => NodeGit.Signature.now("unknown", "unknown")); | ||
| }; | ||
|
|
||
| Reference.updateTerminal = function ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository.prototype.createCommitis able to handle updates to refs which do not exist because of the internal implementation ofgit_commit_createin libgit2. This PR exposes a reimplementation of this functionality so thatRepository.prototype.createCommitWithSignatureexhibits the same functionality.