Breaking: Repository.prototype.continueRebase enhancements #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One example of a meaningful exception occurring in `continueRebase` is for the signing callback to throw because of an invalid key passphrase. In such chases, errors should not be swallowed. In nodegit#1348, EAPPLIED was mentioned specifically as en error that we would like to swallow.
implausible
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement to the
Repository.prototype.continueRebasemethod which allows aRebaseOptionsto be passed in. This achieves parity withRepository.prototype.rebaseBranches.Also introduces a breaking change from the error handling pattern introduced to
continueRebasein BREAKING: Convert sync methods to async methods #1348. Previously, all errors which occurred in the middle of acontinueRebaseoperation would be swallowed. However, the introduction ofsigningCbas a field onRebaseOptionsshed light on legitimate use cases wherecontinueRebaseshould throw. My solution was to swallow theEAPPLIEDerror (specifically mentioned in the review of BREAKING: Convert sync methods to async methods #1348) and throw all others.