Skip to content

Fix issues with Commit#amendWithSignature#1617

Merged
implausible merged 4 commits into
nodegit:masterfrom
emmax86:fix/amend-with-signature-issues
Jan 30, 2019
Merged

Fix issues with Commit#amendWithSignature#1617
implausible merged 4 commits into
nodegit:masterfrom
emmax86:fix/amend-with-signature-issues

Conversation

@emmax86

@emmax86 emmax86 commented Jan 29, 2019

Copy link
Copy Markdown
Collaborator

Fixes two issues with the Commit#amendWithSignature method:

  1. Non-null arguments which override the values from the commit object were being ignored.
  2. An extra newline was being inserted into the commit message. This caused extraneous newlines to be appended to commit messages, esp. when the amend operation was repeated.

@emmax86

emmax86 commented Jan 30, 2019

Copy link
Copy Markdown
Collaborator Author

As a follow up, I would love to see if we could use the git_message_prettify function in libgit2 for formatting messages before passing them into the commit buffer. However, it does not seem to be exposed at the moment.

@implausible implausible merged commit d06945e into nodegit:master Jan 30, 2019
@emmax86 emmax86 deleted the fix/amend-with-signature-issues branch January 30, 2019 19:07
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@implausible implausible implausible approved these changes

Assignees

@implausible implausible

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emmax86 @implausible