Skip to content

Add yarn install #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuckyPigeon wants to merge 6 commits into from
Closed

Add yarn install #1612

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20c66f0
Add yarn install
LuckyPigeon Jan 23, 2019
2ee5c5d
Update #1612
LuckyPigeon Jan 30, 2019
daebc14
Update preinstall.js
LuckyPigeon Feb 1, 2019
21bc746
Move yarn install block after npm install
LuckyPigeon Feb 3, 2019
6a5b1e1
Update preinstall.js
LuckyPigeon Feb 3, 2019
0c8b282
Fix indentation from 4 spaces to 6 spaces
LuckyPigeon Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lifecycleScripts/preinstall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,26 @@ module.exports = function prepareForBuild() {
return exec("npm -v")
.then(function(npmVersion) {
if (npmVersion.split(".")[0] < 3) {
console.log("[nodegit] npm@2 installed, pre-loading required packages");
console.log("[nodegit] npm@2 installed, " +
"pre-loading required packages");
return exec("npm install --ignore-scripts");
}

return Promise.resolve();
})
.catch(function(err) {
console.log("npm install failed, change to yarn install");
return exec("yarn --version")
.then(function(yarnVersion) {
if (yarnVersion.split(".")[0] < 1) {
console.log("[nodegit] yarn installed, " +
"pre-loading required packages");
return exec("yarn install --ignore-scripts");
}

return Promise.resolve();
});
})
.then(function() {
if (buildFlags.isGitRepo) {
var submodules = require(local("submodules"));
Expand Down