-
Notifications
You must be signed in to change notification settings - Fork 697
Add yarn install #1612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarn install #1612
Conversation
|
related to #1593 |
implausible
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help! Would you please fix the indentation in these in your promise methods and consider adjusting the flow of your promise chain as I've suggested in my review?
LuckyPigeon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@implausible Updated
|
@implausible I've seen the change requested. I not entirely understand what your "fix the indentation" means, could you explain it more precisely? |
|
@implausible Updated |
|
Hrmm.. So upon further review of this code, I noticed that the current patch is proposing to run If you follow the code, we perform I believe that yarn's behavior will mirror that of I think the patch that we're actually looking for looks like this: Can you confirm this solves your issue? |
|
Closed in favor of #1644 |
No description provided.