Skip to content

Use curl-config to find curl #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 2 commits into from
Sep 26, 2018
Merged

Use curl-config to find curl #1555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7623c4b
Use curl-config to find curl
saper Feb 26, 2017
0e6bb92
Mention curl-config in readme
Croydon Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ In Ubuntu:
sudo apt-get install libssl-dev
```

Additionally, you need `curl-config` on your system. You need one of these packages:
* libcurl4-gnutls-dev
* libcurl4-nss-dev
* libcurl4-openssl-dev

If you are still encountering problems while installing, you should try the
[Building from source](http://www.nodegit.org/guides/install/from-source/)
instructions.
Expand Down
4 changes: 2 additions & 2 deletions generate/templates/templates/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@
}
],
[
"OS=='linux' or OS=='mac'", {
"OS=='linux' or OS=='mac' or OS.endswith('bsd')", {
"libraries": [
"-lcurl"
"<!(curl-config --libs)"
]
}
],
Expand Down
3 changes: 2 additions & 1 deletion vendor/libgit2.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@
}],
["OS=='mac' or OS=='linux' or OS.endswith('bsd')", {
"cflags": [
"-DGIT_CURL"
"-DGIT_CURL",
"<!(curl-config --cflags)"
],
"defines": [
"GIT_CURL",
Expand Down