Update package.json engines to reflect lack of 10 support #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we're close to getting Node 10 support, so I may want to hold off on this. If I'm wrong, we can merge and push out a patch? |
Member
|
We're pretty close. I'm hoping we can wrap it up this week and Node 10 support will arrive at the same time that Node 10 LTS arrives. |
Merged
Collaborator
Author
|
WHAT YOU DON'T WANT TO MERGE THIS NOW THAT IT'S WRONG?! |
Member
|
I even went so far as to delete you branch, let this be a lesson about being wrong. |
Member
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesnt mean much directly, except npm will warn and yarn I think will error if you try to install with node 10. Just to provide a bit of feedback to people running into that, since it seems to be coming up a lot.