Skip to content

Fix behavior of Commit#parent #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 1 commit into from
Jan 21, 2020
Merged

Fix behavior of Commit#parent #1509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/commit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,24 @@ var _parent = Commit.prototype.parent;
*/
Commit.lookup = LookupWrapper(Commit);

/**
* @async
* @param {Number} n
* @return {Commit}
*/
Commit.prototype.parent = function(n, callback) {
var repo = this.repo;
return _parent.call(this, n).then(p => {
p.repo = repo;

if (typeof callback === "function") {
callback(null, p);
}

return p;
}, callback);
};

/**
* Amend a commit
* @async
Expand Down
10 changes: 10 additions & 0 deletions test/tests/commit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,6 +774,16 @@ describe("Commit", function() {
assert.equal(1, this.commit.parentcount());
});

it("can fetch a single parent", function() {
return this.commit.parent(0).then(function(parent) {
assert.strictEqual(parent.sha(),
"ecfd36c80a3e9081f200dfda2391acadb56dac27");
// This used to crash due to a missing .repo property on the retrieved
// parent.
return parent.getTree().then(tree => assert(tree));
});
});

it("can retrieve and walk a commit tree", function() {
var commitTreeEntryCount = 0;
var expectedCommitTreeEntryCount = 198;
Expand Down