Skip to content

Conversation

@tbranyen
Copy link
Member

@tbranyen tbranyen commented Jun 5, 2018

Fixes Node 10 issues.

@tbranyen
Copy link
Member Author

tbranyen commented Jun 5, 2018

NPM is having consistency issues ATM. Published 0.5.0, but NPM reports 0.4.0 as latest. I'll try again later in the day.

@tbranyen tbranyen force-pushed the bump-promisify-node branch from 3930624 to 0f87857 Compare June 5, 2018 17:02
@tbranyen
Copy link
Member Author

tbranyen commented Jun 5, 2018

Looks like I broke some tests with the latest promisify-node. I'll work on addressing these, once NodeGit builds on Node 10.

@Croydon
Copy link
Contributor

Croydon commented Sep 29, 2018

Is this commit helping? 55e5a35

However, be careful, this might cause a freeze in the tests with Node 6 on Windows as I have experienced in #1519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants