Skip to content

Bump the promisify-node package#1506

Closed
tbranyen wants to merge 1 commit into
masterfrom
bump-promisify-node
Closed

Bump the promisify-node package#1506
tbranyen wants to merge 1 commit into
masterfrom
bump-promisify-node

Conversation

@tbranyen

@tbranyen tbranyen commented Jun 5, 2018

Copy link
Copy Markdown
Member

Fixes Node 10 issues.

@tbranyen

tbranyen commented Jun 5, 2018

Copy link
Copy Markdown
Member Author

NPM is having consistency issues ATM. Published 0.5.0, but NPM reports 0.4.0 as latest. I'll try again later in the day.

@tbranyen tbranyen force-pushed the bump-promisify-node branch from 3930624 to 0f87857 Compare June 5, 2018 17:02
@tbranyen

tbranyen commented Jun 5, 2018

Copy link
Copy Markdown
Member Author

Looks like I broke some tests with the latest promisify-node. I'll work on addressing these, once NodeGit builds on Node 10.

@Croydon

Croydon commented Sep 29, 2018

Copy link
Copy Markdown
Contributor

Is this commit helping? 55e5a35

However, be careful, this might cause a freeze in the tests with Node 6 on Windows as I have experienced in #1519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants