Skip to content

Expose error code in Status.file #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 1 commit into from
Apr 6, 2018
Merged

Expose error code in Status.file #1468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions generate/input/descriptor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2533,10 +2533,10 @@
"status_flags": {
"isReturn": true,
"shouldAlloc": true
},
"return": {
"isErrorCode": true
}
},
"return": {
"isErrorCode": true
}
},
"git_status_foreach": {
Expand Down
20 changes: 20 additions & 0 deletions test/tests/status.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,27 @@ describe("Status", function() {
.then(function() {
return Promise.reject(e);
});
});
});

it("gets status on non-existent file results in error", function() {
var fileName = "non-existent-Status.file-test.txt";
var repo = this.repository;
var filePath = path.join(repo.workdir(), fileName);
return exec("git clean -xdf", {cwd: reposPath})
.then(function() {
assert.equal(false, fse.existsSync(filePath));
return Status.file(repo, filePath)
.then(function() {
assert.fail("Non-existent file should throw error on Status.file");
}, function(err) {
assert.equal(NodeGit.Error.CODE.ENOTFOUND, err.errno);
assert.equal("Status.file", err.errorFunction);
assert.equal(
"attempt to get status of nonexistent file '" + filePath + "'",
err.message
);
});
});
});
});