Adding git_filter support in nodegit #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsyncBatonWithNoResults wip 2
Build + test register complete filter init test wip
Adding subtract filter + refactoring template code to eliminate new self() in cc code filter registry update + templating changes
working filters!! (for now)
Reached Async Land adding error handling testing commit + apply callback fixed field_accessor template on windows
implementing checks in test suite added more filter tests lol CRLF Added more unit tests
mohseenrm
force-pushed
the
feature/git-filter
branch
from
e37c852 to
8c6d2a5
Compare
implausible
requested changes
Jul 26, 2017
generate/scripts/generateJson.js
Outdated
| }, {}).valueOf(); | ||
|
|
||
| // decorate the definitions with required data to build the C++ files | ||
| //TODO: add self ref tag here |
Member
There was a problem hiding this comment.
Is this comment needed anymore?
| } | ||
|
|
||
| if (cArg === args.length -1) { | ||
| arg.lastArg = true; |
Member
There was a problem hiding this comment.
This entire block is:
arg.lastArg = cArg === args.length - 1;
arg.firstArg = !arg.lastArg && cArg === 0;| @@ -0,0 +1,3 @@ | |||
| module.exports = function(value, other) { | |||
| return (value - other); | |||
Member
There was a problem hiding this comment.
This doesn't need parentheses.
|
|
||
| struct AsyncBatonWithNoResult : public AsyncBaton { | ||
| /* ResultT result; | ||
| ResultT defaultResult;*/ // result returned if the callback doesn't return anything valid |
Member
There was a problem hiding this comment.
This comment does not apply to this structure.
| @@ -0,0 +1,85 @@ | |||
| // This is a generated file, modify: generate/templates/templates/class_header.h | |||
Member
There was a problem hiding this comment.
This is not a generated file.
test/tests/filter.js
Outdated
| check: function(src, attr) { | ||
| return src.path() === "README.md" ? 0 : GIT_PASSTHROUGH; | ||
| }, | ||
| cleanup: function() { |
test/tests/filter.js
Outdated
| }, 0) | ||
| .then(function(result) { | ||
| global.gc(); | ||
| assert.strictEqual(result, 0); |
test/tests/filter.js
Outdated
| .then(function() { | ||
| return commitFile(test.repository, "README.md", | ||
| "testing commit contents", | ||
| "test commit"); |
test/tests/filter.js
Outdated
| }) | ||
| .then(function(commit) { | ||
| var postInitializeReadmeContents = fse.readFileSync( | ||
| readmePath, "utf-8"); |
Contributor
Author
There was a problem hiding this comment.
added these fixes in
test/tests/filter.js
Outdated
| } | ||
| }, 0) | ||
| .then(function(result) { | ||
| assert.strictEqual(result, 0); |
mohseenrm
force-pushed
the
feature/git-filter
branch
from
f0e45be to
4c73221
Compare
mohseenrm
force-pushed
the
feature/git-filter
branch
from
4c73221 to
debcf21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for git_filter to nodegit.
Changes:
Filters are now asynchronous,
FilterRegistry added to register and unregister filters.