build: use pkg-config to find curl header #1328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkgsrc (as used by NetBSD) installs package headers in non default locations. The solution is to use pkg-config to work out the correct location via CFLAGS.
This un-breaks the windows build.
Member
|
Looks good to me 👍 |
removed node v4 tests
Bump libgit2 to maintenance v0.26
AsyncBatonWithNoResults wip 2
Build + test register complete filter init test wip
Adding subtract filter + refactoring template code to eliminate new self() in cc code filter registry update + templating changes
working filters!! (for now)
Reached Async Land adding error handling testing commit + apply callback fixed field_accessor template on windows
implementing checks in test suite added more filter tests lol CRLF Added more unit tests
Add CI build config for node stable version
Adding git_filter support in nodegit
Exposed libgit2 git_branch_remote_name method
pkgsrc (as used by NetBSD) installs package headers in non default locations. The solution is to use pkg-config to work out the correct location via CFLAGS.
This un-breaks the windows build.
Contributor
Author
|
no idea what happened here, I'll redo |
|
The |
Contributor
Author
|
See PR #1237 for a better solution. Bump that one instead ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkgsrc (as used by NetBSD) installs package headers in non default
locations.
The solution is to use pkg-config to work out the correct location
via CFLAGS.