Use curl-config to find curl #1237
Conversation
|
Maybe this would even work for Windows? |
|
The only reason to bring libcurl into NodeGit is to enable proxy and authenticated proxy transports in OSX and Linux. Windows already has full support for proxies. |
|
@saper should rebase this on master so the 32 bit linux tests passes. This is definitely a good idea. |
|
@saper could you rebase this please? I'd like to get this in for the next release. Thanks! |
On BSDs headers will be in /usr/local/include which is not added to the include path automatically.
|
Rebased... well it was master and the time I wrote this :) and there were no conflicts |
|
What needs to be done here to progress this? |
|
Please merge this, |
|
Are there plans to include this patch, I can confirm that it fixed the problem. |
On BSDs headers will be in /usr/local/include which is not added to the include path automatically. (cherry picked from commit 785f184) [nodegit#1237]
|
The code in this pull request helps with the build on FreeBSD and Ubuntu 16.04. Hopefully it can get merged soon. I see that there is an error in a build on windows done by appveyor, this seems unrelated to the code changes here which do not affect windows as far as I understand. |
|
@implausible Can we merge this now? Both #1545 and #1519 is containing it too, but getting this done step by step seems reasonable. |
|
@Croydon The tests are failing. @saper Any chance you can rebase this to get the tests running again on CI? It looks like Travis doesn't even know about this PR. Otherwise if @saper is unavailable, I would support it if you, @Croydon, took control of this PR by opening a new branch + PR with it. We would close this PR, reference this PR in your PR, and merge your PR. |
8 participants
On BSDs headers will be in /usr/local/include which
is not added to the include path automatically.
Follow-up-to: #1195