build against shared library for libcurl #1195
Conversation
First pass of proxyOpts normalization
|
Testing this is proving to be quite difficult. Issues are that we want to assert that we (@cbargren in da house) are going over a proxy. We need to figure out a way to create a proxy on the fly on our test boxes that we can tell nodegit to use that also can be checked at the end of the test if it was hit or not... we've looked through several libraries today and so far nothing is working for us :( |
implausible
force-pushed
the
feature/enable-curl-support
branch
from
56ea77f to
308f0ae
Compare
|
Getting proxy options fully tested is going to be very difficult. For now, this passes all of the test cases, and does not worsen NodeGit. Had a discussion with @johnhaley81, we'll come back for tests on this when we have a good framework for an on-the-fly forward proxy. |
|
Probably a custom proxy through express or something would be easiest. |
|
Looking at this now. |
|
Tested this in a proxied environment and confirmed it worked. Thanks @implausible. |
|
this breaks my FreeBSD build since it cannot find This change should use |
5 participants
To get proxy support into NodeGit, we will need to get libgit configured to use libcurl. To start, we will just try to build nodegit against libcurl using the -lcurl flag.
We will also expose and handle proxy_options, the goal of this PR is to get proxy support in full across all systems.
This should address #489