Fixup refreshReferences

implausible · implausible · commit f4926a0a534e · 2019-04-23T16:31:20.000-07:00
Reset baton-&gt;error_code to GIT_OK on clean loop exit.
Use \\s instead of \s for regex string
diff --git a/generate/templates/manual/repository/refresh_references.cc b/generate/templates/manual/repository/refresh_references.cc
@@ -148,7 +148,7 @@ class RefreshedRefModel {
       x509Array,
       Nan::New<Number>(0),
       Nan::New<v8::RegExp>(
-        Nan::New("-----BEGIN SIGNED MESSAGE-----[\s\S]+?-----END SIGNED MESSAGE-----").ToLocalChecked(),
+        Nan::New("-----BEGIN SIGNED MESSAGE-----[\\s\\S]+?-----END SIGNED MESSAGE-----").ToLocalChecked(),
         static_cast<v8::RegExp::Flags>(v8::RegExp::Flags::kGlobal | v8::RegExp::Flags::kMultiline)
       ).ToLocalChecked()
     );
@@ -556,6 +556,8 @@ void GitRepository::RefreshReferencesWorker::Execute()
 
     if (baton->error_code == GIT_OK) {
       refreshData->refs.push_back(refreshedRefModel);
+    } else {
+      baton->error_code = GIT_OK;
     }
   }
 
