Wip: Strange bug on Windows Node 14 x64 in CI.

implausible · implausible · commit f1b5b7dfee37 · 2020-08-14T13:59:16.000-07:00
diff --git a/generate/templates/manual/src/promise_completion.cc b/generate/templates/manual/src/promise_completion.cc
@@ -51,20 +51,28 @@ NAN_METHOD(PromiseCompletion::New) {
 
 // sets up a Promise to forward the promise result via the baton and callback
 void PromiseCompletion::Setup(v8::Local<v8::Function> thenFn, v8::Local<v8::Value> result, AsyncBaton *baton, Callback callback) {
+  Nan::HandleScope scope;
+
+  std::cout << "Entering PromiseCompletion::Setup" << std::endl;
+
   this->callback = callback;
   this->baton = baton;
 
   v8::Local<v8::Object> promise = Nan::To<v8::Object>(result).ToLocalChecked();
 
   v8::Local<v8::Object> thisHandle = handle();
 
+  std::cout << "Binding arguments" << std::endl;
+
   v8::Local<v8::Value> argv[2] = {
     Bind(promiseFulfilled, thisHandle),
     Bind(promiseRejected, thisHandle)
   };
 
+  std::cout << "Calling thenFn" << std::endl;
   // call the promise's .then method with resolve and reject callbacks
   Nan::Call(Nan::Callback(thenFn), promise, 2, argv);
+  std::cout << "Called then function" << std::endl;
 }
 
 // binds an object to be the context of the function.
@@ -84,6 +92,7 @@ v8::Local<v8::Value> PromiseCompletion::Bind(Nan::Persistent<v8::Function> &func
 // calls the callback stored in the PromiseCompletion, passing the baton that
 // was provided in construction
 void PromiseCompletion::CallCallback(bool isFulfilled, const Nan::FunctionCallbackInfo<v8::Value> &info) {
+  Nan::HandleScope scope;
   v8::Local<v8::Value> resultOfPromise;
 
   if (info.Length() > 0) {
diff --git a/generate/templates/manual/src/thread_pool.cc b/generate/templates/manual/src/thread_pool.cc
@@ -1,4 +1,5 @@
 #include "../include/thread_pool.h"
+#include <iostream>
 
 ThreadPool::ThreadPool(int numberOfThreads, uv_loop_t *loop) {
   uv_mutex_init(&workMutex);
@@ -99,4 +100,5 @@ void ThreadPool::RunLoopCallbacks() {
     }
     uv_mutex_unlock(&workMutex);
   }
+  std::cout << "Exiting RunLoopCallbacks" << std::endl;
 }
diff --git a/generate/templates/partials/field_accessors.cc b/generate/templates/partials/field_accessors.cc
@@ -213,6 +213,9 @@
         }
 
         if(PromiseCompletion::ForwardIfPromise(result, baton, {{ cppClassName }}::{{ field.name }}_promiseCompleted)) {
+          {% if field.name == "credentials" %}
+          std::cout << "Forwarding credentials" << std::endl;
+          {% endif %}
           return;
         }
 
@@ -250,6 +253,10 @@
       void {{ cppClassName }}::{{ field.name }}_promiseCompleted(bool isFulfilled, AsyncBaton *_baton, v8::Local<v8::Value> result) {
         Nan::HandleScope scope;
 
+        {% if field.name == "credentials" %}
+        std::cout << "promise completed for credentials" << std::endl;
+        {% endif %}
+
         {{ field.name|titleCase }}Baton* baton = static_cast<{{ field.name|titleCase }}Baton*>(_baton);
         {% if field.return.type == "void" %}
           baton->Done();
diff --git a/generate/templates/templates/struct_header.h b/generate/templates/templates/struct_header.h
@@ -5,6 +5,7 @@
 #include <queue>
 #include <utility>
 #include <unordered_map>
+#include <iostream>
 
 #include "async_baton.h"
 #include "callback_wrapper.h"
diff --git a/test/tests/remote.js b/test/tests/remote.js
@@ -346,6 +346,7 @@ describe("Remote", function() {
 
   if (!isNode8) {
     it("will reject if credentials promise rejects", function() {
+      this.timeout(60000);
       var repo = this.repository;
       var branch = "should-not-exist";
       return Remote.lookup(repo, "origin")
@@ -356,10 +357,20 @@ describe("Remote", function() {
           callbacks: {
             credentials: function(url, userName) {
               var test = Promise.resolve("test")
-              .then(function() { return; })
-              .then(function() { return; })
-              .then(function() { return; })
               .then(function() {
+                console.log("1");
+                return;
+              })
+              .then(function() {
+                console.log("2");
+                return;
+              })
+              .then(function() {
+                console.log("3");
+                return;
+              })
+              .then(function() {
+                console.log("4");
                 return Promise.reject(new Error("failure case"));
               });
               return test;
@@ -390,10 +401,22 @@ describe("Remote", function() {
             callbacks: {
               credentials: function(url, userName) {
                 var test = Promise.resolve()
-                .then(Promise.resolve.bind(Promise))
-                .then(Promise.resolve.bind(Promise))
-                .then(Promise.resolve.bind(Promise))
-                .then(Promise.reject.bind(Promise));
+                  .then(() => {
+                    console.log("1");
+                    return Promise.resolve();
+                  })
+                  .then(() => {
+                    console.log("2");
+                    return Promise.resolve();
+                  })
+                  .then(() => {
+                    console.log("3");
+                    return Promise.resolve();
+                  })
+                  .then(() => {
+                    console.log("4");
+                    return Promise.reject();
+                  });
                 return test;
               },
               certificateCheck: () => 0

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#include "../include/thread_pool.h"`
	`2`	`+#include <iostream>`
`2`	`3`
`3`	`4`	`ThreadPool::ThreadPool(int numberOfThreads, uv_loop_t *loop) {`
`4`	`5`	`uv_mutex_init(&workMutex);`
`@@ -99,4 +100,5 @@ void ThreadPool::RunLoopCallbacks() {`
`99`	`100`	`}`
`100`	`101`	`uv_mutex_unlock(&workMutex);`
`101`	`102`	`}`
	`103`	`+ std::cout << "Exiting RunLoopCallbacks" << std::endl;`
`102`	`104`	`}`