Remove config_snapshot hack from refresh_references

implausible · implausible · commit b05db5f4ab69 · 2019-07-23T14:08:53.000-07:00
We needed to perform this hack to get libgit2 to re-read the config on git_remote_list. Now that git_remote_list always reads the config, we don't need to force the config to update via a config_snapshot request
diff --git a/generate/templates/manual/repository/refresh_references.cc b/generate/templates/manual/repository/refresh_references.cc
@@ -429,20 +429,6 @@ void GitRepository::RefreshReferencesWorker::Execute()
     return;
   }
 
-  git_config *config;
-  baton->error_code = git_repository_config_snapshot(&config, repo);
-  if (baton->error_code != GIT_OK) {
-    if (giterr_last() != NULL) {
-      baton->error = git_error_dup(giterr_last());
-    }
-    git_odb_free(odb);
-    delete refreshData;
-    baton->out = NULL;
-    return;
-  }
-  git_config_free(config);
-
-
   // START Refresh HEAD
   git_reference *headRef = NULL;
   baton->error_code = lookupDirectReferenceByShorthand(&headRef, repo, "HEAD");
@@ -544,7 +530,7 @@ void GitRepository::RefreshReferencesWorker::Execute()
     if (reference == NULL) {
       // lookup found the reference but failed to resolve it directly
       continue;
-    } 
+    }
 
     UpstreamModel *upstreamModel;
     if (UpstreamModel::fromReference(&upstreamModel, reference)) {
