⬆️ Minor amends for a few manual templates

tiggerite · tiggerite · commit 77b615a6ebd0 · 2019-07-10T10:10:06.000+01:00
diff --git a/generate/templates/manual/src/filter_registry.cc b/generate/templates/manual/src/filter_registry.cc
@@ -64,7 +64,7 @@ NAN_METHOD(GitFilterRegistry::GitFilterRegister) {
   baton->error_code = GIT_OK;
   baton->filter_priority = Nan::To<int>(info[2]).FromJust();
 
-  Nan::New(GitFilterRegistry::persistentHandle)->Set(Nan::To<v8::Object>(Nan::To<v8::String>(info[0]).ToLocalChecked(), info[1]).ToLocalChecked());
+  Nan::New(GitFilterRegistry::persistentHandle)->Set(Nan::To<v8::String>(info[0]).ToLocalChecked(), Nan::To<v8::Object>(info[1]).ToLocalChecked());
 
   Nan::Callback *callback = new Nan::Callback(Local<Function>::Cast(info[3]));
   RegisterWorker *worker = new RegisterWorker(baton, callback);
diff --git a/generate/templates/manual/src/git_buf_converter.cc b/generate/templates/manual/src/git_buf_converter.cc
@@ -10,7 +10,7 @@ using namespace node;
 
 git_buf *GitBufConverter::Convert(Local<v8::Value> val) {
   if (val->IsString() || val->IsStringObject()) {
-    v8::String::Utf8Value param1(Nan::To<v8::String>(val).ToLocalChecked());
+    Nan::Utf8String param1(Nan::To<v8::String>(val).ToLocalChecked());
     std::string v8String = std::string(*param1);
 
     const size_t size = sizeof(git_buf);
diff --git a/generate/templates/manual/src/nodegit_wrapper.cc b/generate/templates/manual/src/nodegit_wrapper.cc
@@ -67,7 +67,7 @@ NAN_METHOD(NodeGitWrapper<Traits>::JSNewFunction) {
     instance = new cppClass(static_cast<cType *>(
       Local<External>::Cast(info[0])->Value()),
       Nan::To<bool>(info[1]).FromJust(),
-      info.Length() >= 3 && !Nan::To<v8::Object>(info[2].IsEmpty() && info[2]->IsObject() ? info[2]).ToLocalChecked() : Local<v8::Object>()
+      info.Length() >= 3 && !info[2].IsEmpty() && info[2]->IsObject() ? Nan::To<v8::Object>(info[2]).ToLocalChecked() : Local<v8::Object>()
     );
   }
 
diff --git a/generate/templates/partials/field_accessors.cc b/generate/templates/partials/field_accessors.cc
@@ -43,7 +43,7 @@
 
         wrapper->{{ field.name }}.Reset({{ field.name }});
 
-        wrapper->raw->{{ field.name }} = {% if not field.cType | isPointer %}*{% endif %}{% if field.cppClassName == 'GitStrarray' %}StrArrayConverter::Convert(Nan::To<v8::Object>({{ field.name }}).ToLocalChecked())){% else %}Nan::ObjectWrap::Unwrap<{{ field.cppClassName }}>(Nan::To<v8::Object>({{ field.name }}).ToLocalChecked())->GetValue(){% endif %};
+        wrapper->raw->{{ field.name }} = {% if not field.cType | isPointer %}*{% endif %}{% if field.cppClassName == 'GitStrarray' %}StrArrayConverter::Convert(Nan::To<v8::Object>({{ field.name }}).ToLocalChecked()){% else %}Nan::ObjectWrap::Unwrap<{{ field.cppClassName }}>(Nan::To<v8::Object>({{ field.name }}).ToLocalChecked())->GetValue(){% endif %};
 
       {% elsif field.isCallbackFunction %}
         Nan::Callback *callback = NULL;

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ NAN_METHOD(NodeGitWrapper<Traits>::JSNewFunction) {`
`67`	`67`	`instance = new cppClass(static_cast<cType *>(`
`68`	`68`	`Local<External>::Cast(info[0])->Value()),`
`69`	`69`	`Nan::To<bool>(info[1]).FromJust(),`
`70`		`- info.Length() >= 3 && !Nan::To<v8::Object>(info[2].IsEmpty() && info[2]->IsObject() ? info[2]).ToLocalChecked() : Local<v8::Object>()`
	`70`	`+ info.Length() >= 3 && !info[2].IsEmpty() && info[2]->IsObject() ? Nan::To<v8::Object>(info[2]).ToLocalChecked() : Local<v8::Object>()`
`71`	`71`	`);`
`72`	`72`	`}`
`73`	`73`