Remove HandleScope from Set

srajko · srajko · commit 6b66c8be0c02 · 2016-03-08T14:30:00.000-07:00
This HandeScope was introduced with throttling changes, and may have contributed to the crash.
diff --git a/generate/templates/partials/field_accessors.cc b/generate/templates/partials/field_accessors.cc
@@ -31,8 +31,6 @@
     }
 
     NAN_SETTER({{ cppClassName }}::Set{{ field.cppFunctionName }}) {
-      Nan::HandleScope scope;
-
       {{ cppClassName }} *wrapper = Nan::ObjectWrap::Unwrap<{{ cppClassName }}>(info.This());
 
       {% if field.isEnum %}

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,6 @@`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`NAN_SETTER({{ cppClassName }}::Set{{ field.cppFunctionName }}) {`
`34`		`- Nan::HandleScope scope;`
`35`		`-`
`36`	`34`	`{{ cppClassName }} *wrapper = Nan::ObjectWrap::Unwrap<{{ cppClassName }}>(info.This());`
`37`	`35`
`38`	`36`	`{% if field.isEnum %}`