Skip to content

Commit 658936e

Browse files
tiggeritetiggerite
committed
♻️ Remove last depreciated warnings so everything is now clean
1 parent 9bc65c6 commit 658936e

20 files changed

Lines changed: 80 additions & 86 deletions

‎generate/templates/manual/clone/clone.cc‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,8 @@ void GitClone::CloneWorker::HandleOKCallback() {
144144
} else {
145145
err = Nan::To<v8::Object>(Nan::Error("Method clone has thrown an error.")).ToLocalChecked();
146146
}
147-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
148-
err->Set(Nan::New("errorFunction").ToLocalChecked(),
147+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
148+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(),
149149
Nan::New("Clone.clone").ToLocalChecked());
150150
v8::Local<v8::Value> argv[1] = {err};
151151
callback->Call(1, argv, async_resource);
@@ -184,8 +184,8 @@ void GitClone::CloneWorker::HandleOKCallback() {
184184
for (unsigned int propIndex = 0; propIndex < properties->Length();
185185
++propIndex) {
186186
v8::Local<v8::String> propName =
187-
Nan::To<v8::String>(properties->Get(propIndex)).ToLocalChecked();
188-
v8::Local<v8::Value> nodeToQueue = nodeObj->Get(propName);
187+
Nan::To<v8::String>(Nan::Get(properties, propIndex).ToLocalChecked()).ToLocalChecked();
188+
v8::Local<v8::Value> nodeToQueue = Nan::Get(nodeObj, propName).ToLocalChecked();
189189
if (!nodeToQueue->IsUndefined()) {
190190
workerArguments.push(nodeToQueue);
191191
}
@@ -195,9 +195,9 @@ void GitClone::CloneWorker::HandleOKCallback() {
195195
if (!callbackFired) {
196196
v8::Local<v8::Object> err =
197197
Nan::To<v8::Object>(Nan::Error("Method clone has thrown an error.")).ToLocalChecked();
198-
err->Set(Nan::New("errno").ToLocalChecked(),
198+
Nan::Set(err,Nan::New("errno").ToLocalChecked(),
199199
Nan::New(baton->error_code));
200-
err->Set(Nan::New("errorFunction").ToLocalChecked(),
200+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(),
201201
Nan::New("Clone.clone").ToLocalChecked());
202202
v8::Local<v8::Value> argv[1] = {err};
203203
callback->Call(1, argv, async_resource);

‎generate/templates/manual/commit/extract_signature.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,8 @@ void GitCommit::ExtractSignatureWorker::HandleOKCallback()
133133
else if (baton->error_code < 0)
134134
{
135135
Local<v8::Object> err = Nan::To<v8::Object>(Nan::Error("Extract Signature has thrown an error.")).ToLocalChecked();
136-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
137-
err->Set(Nan::New("errorFunction").ToLocalChecked(), Nan::New("Commit.extractSignature").ToLocalChecked());
136+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
137+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(), Nan::New("Commit.extractSignature").ToLocalChecked());
138138
Local<v8::Value> argv[1] = {
139139
err
140140
};

‎generate/templates/manual/filter_list/load.cc‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ void GitFilterList::LoadWorker::HandleOKCallback() {
143143
);
144144

145145
for (uint32_t index = 0; index < propertyNames->Length(); ++index) {
146-
v8::Local<v8::String> propertyName = Nan::To<v8::String>(propertyNames->Get(index)).ToLocalChecked();
146+
v8::Local<v8::String> propertyName = Nan::To<v8::String>(Nan::Get(propertyNames, index).ToLocalChecked()).ToLocalChecked();
147147
Nan::Utf8String propertyNameAsUtf8Value(propertyName);
148148
const char *propertyNameAsCString = *propertyNameAsUtf8Value;
149149

@@ -153,7 +153,7 @@ void GitFilterList::LoadWorker::HandleOKCallback() {
153153
Nan::Set(
154154
owners,
155155
Nan::New<Number>(owners->Length()),
156-
filterRegistry->Get(propertyName)
156+
Nan::Get(filterRegistry, propertyName).ToLocalChecked()
157157
);
158158
}
159159
}
@@ -176,8 +176,8 @@ void GitFilterList::LoadWorker::HandleOKCallback() {
176176
} else {
177177
err = Nan::To<v8::Object>(Nan::Error("Method load has thrown an error.")).ToLocalChecked();
178178
}
179-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
180-
err->Set(Nan::New("errorFunction").ToLocalChecked(),
179+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
180+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(),
181181
Nan::New("FilterList.load").ToLocalChecked());
182182
v8::Local<v8::Value> argv[1] = {err};
183183
callback->Call(1, argv, async_resource);
@@ -218,8 +218,8 @@ void GitFilterList::LoadWorker::HandleOKCallback() {
218218
for (unsigned int propIndex = 0; propIndex < properties->Length();
219219
++propIndex) {
220220
v8::Local<v8::String> propName =
221-
Nan::To<v8::String>(properties->Get(propIndex)).ToLocalChecked();
222-
v8::Local<v8::Value> nodeToQueue = nodeObj->Get(propName);
221+
Nan::To<v8::String>(Nan::Get(properties, propIndex).ToLocalChecked()).ToLocalChecked();
222+
v8::Local<v8::Value> nodeToQueue = Nan::Get(nodeObj, propName).ToLocalChecked();
223223
if (!nodeToQueue->IsUndefined()) {
224224
workerArguments.push(nodeToQueue);
225225
}
@@ -229,9 +229,9 @@ void GitFilterList::LoadWorker::HandleOKCallback() {
229229
if (!callbackFired) {
230230
v8::Local<v8::Object> err =
231231
Nan::To<v8::Object>(Nan::Error("Method load has thrown an error.")).ToLocalChecked();
232-
err->Set(Nan::New("errno").ToLocalChecked(),
232+
Nan::Set(err,Nan::New("errno").ToLocalChecked(),
233233
Nan::New(baton->error_code));
234-
err->Set(Nan::New("errorFunction").ToLocalChecked(),
234+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(),
235235
Nan::New("FilterList.load").ToLocalChecked());
236236
v8::Local<v8::Value> argv[1] = {err};
237237
callback->Call(1, argv, async_resource);

‎generate/templates/manual/filter_source/repo.cc‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ void GitFilterSource::RepoWorker::HandleOKCallback() {
6464
} else {
6565
err = Nan::To<v8::Object>(Nan::Error("Method repo has thrown an error.")).ToLocalChecked();
6666
}
67-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
68-
err->Set(Nan::New("errorFunction").ToLocalChecked(),
67+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
68+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(),
6969
Nan::New("FilterSource.repo").ToLocalChecked());
7070
v8::Local<v8::Value> argv[1] = {err};
7171
callback->Call(1, argv, async_resource);
@@ -75,9 +75,9 @@ void GitFilterSource::RepoWorker::HandleOKCallback() {
7575
} else if (baton->error_code < 0) {
7676
v8::Local<v8::Object> err =
7777
Nan::To<v8::Object>(Nan::Error("Method repo has thrown an error.")).ToLocalChecked();
78-
err->Set(Nan::New("errno").ToLocalChecked(),
78+
Nan::Set(err,Nan::New("errno").ToLocalChecked(),
7979
Nan::New(baton->error_code));
80-
err->Set(Nan::New("errorFunction").ToLocalChecked(),
80+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(),
8181
Nan::New("FilterSource.repo").ToLocalChecked());
8282
v8::Local<v8::Value> argv[1] = {err};
8383
callback->Call(1, argv, async_resource);

‎generate/templates/manual/include/str_array_converter.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ class StrArrayConverter {
1414
static git_strarray *Convert (v8::Local<v8::Value> val);
1515

1616
private:
17-
static git_strarray *ConvertArray(Array *val);
18-
static git_strarray *ConvertString(v8::Local<String> val);
17+
static git_strarray *ConvertArray(v8::Local<v8::Array> val);
18+
static git_strarray *ConvertString(v8::Local<v8::String> val);
1919
static git_strarray *AllocStrArray(const size_t count);
2020
static git_strarray *ConstructStrArray(int argc, char** argv);
2121
};

‎generate/templates/manual/patches/convenient_patches.cc‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ void GitPatch::ConvenientFromDiffWorker::HandleOKCallback() {
101101
} else {
102102
err = Nan::To<v8::Object>(Nan::Error("Method convenientFromDiff has thrown an error.")).ToLocalChecked();
103103
}
104-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
105-
err->Set(Nan::New("errorFunction").ToLocalChecked(), Nan::New("Patch.convenientFromDiff").ToLocalChecked());
104+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
105+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(), Nan::New("Patch.convenientFromDiff").ToLocalChecked());
106106
Local<v8::Value> argv[1] = {
107107
err
108108
};
@@ -119,8 +119,8 @@ void GitPatch::ConvenientFromDiffWorker::HandleOKCallback() {
119119

120120
if (baton->error_code < 0) {
121121
Local<v8::Object> err = Nan::To<v8::Object>(Nan::Error("method convenientFromDiff has thrown an error.")).ToLocalChecked();
122-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
123-
err->Set(Nan::New("errorFunction").ToLocalChecked(), Nan::New("Patch.convenientFromDiff").ToLocalChecked());
122+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
123+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(), Nan::New("Patch.convenientFromDiff").ToLocalChecked());
124124
Local<v8::Value> argv[1] = {
125125
err
126126
};

‎generate/templates/manual/remote/ls.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ void GitRemote::ReferenceListWorker::HandleOKCallback()
8686
else if (baton->error_code < 0)
8787
{
8888
Local<v8::Object> err = Nan::To<v8::Object>(Nan::Error("Reference List has thrown an error.")).ToLocalChecked();
89-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
90-
err->Set(Nan::New("errorFunction").ToLocalChecked(), Nan::New("Remote.referenceList").ToLocalChecked());
89+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
90+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(), Nan::New("Remote.referenceList").ToLocalChecked());
9191
Local<v8::Value> argv[1] = {
9292
err
9393
};

‎generate/templates/manual/repository/get_references.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ void GitRepository::GetReferencesWorker::HandleOKCallback()
119119
else if (baton->error_code < 0)
120120
{
121121
Local<v8::Object> err = Nan::To<v8::Object>(Nan::Error("Repository getReferences has thrown an error.")).ToLocalChecked();
122-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
123-
err->Set(Nan::New("errorFunction").ToLocalChecked(), Nan::New("Repository.getReferences").ToLocalChecked());
122+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
123+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(), Nan::New("Repository.getReferences").ToLocalChecked());
124124
Local<v8::Value> argv[1] = {
125125
err
126126
};

‎generate/templates/manual/repository/get_remotes.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ void GitRepository::GetRemotesWorker::HandleOKCallback()
120120
else if (baton->error_code < 0)
121121
{
122122
Local<v8::Object> err = Nan::To<v8::Object>(Nan::Error("Repository refreshRemotes has thrown an error.")).ToLocalChecked();
123-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
124-
err->Set(Nan::New("errorFunction").ToLocalChecked(), Nan::New("Repository.refreshRemotes").ToLocalChecked());
123+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
124+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(), Nan::New("Repository.refreshRemotes").ToLocalChecked());
125125
Local<v8::Value> argv[1] = {
126126
err
127127
};

‎generate/templates/manual/repository/get_submodules.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ void GitRepository::GetSubmodulesWorker::HandleOKCallback()
101101
else if (baton->error_code < 0)
102102
{
103103
Local<v8::Object> err = Nan::To<v8::Object>(Nan::Error("Repository getSubmodules has thrown an error.")).ToLocalChecked();
104-
err->Set(Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
105-
err->Set(Nan::New("errorFunction").ToLocalChecked(), Nan::New("Repository.getSubmodules").ToLocalChecked());
104+
Nan::Set(err,Nan::New("errno").ToLocalChecked(), Nan::New(baton->error_code));
105+
Nan::Set(err,Nan::New("errorFunction").ToLocalChecked(), Nan::New("Repository.getSubmodules").ToLocalChecked());
106106
Local<v8::Value> argv[1] = {
107107
err
108108
};

0 commit comments

Comments
 (0)