⬆️ GetPropertyNames also needs to be changed for Node 12

tiggerite · tiggerite · commit 59bad9908297 · 2019-07-10T09:52:45.000+01:00
diff --git a/generate/templates/manual/clone/clone.cc b/generate/templates/manual/clone/clone.cc
@@ -180,7 +180,7 @@ void GitClone::CloneWorker::HandleOKCallback() {
           break;
         }
 
-        v8::Local<v8::Array> properties = nodeObj->GetPropertyNames();
+        v8::Local<v8::Array> properties = Nan::GetPropertyNames(nodeObj).ToLocalChecked();
         for (unsigned int propIndex = 0; propIndex < properties->Length();
              ++propIndex) {
           v8::Local<v8::String> propName =
diff --git a/generate/templates/manual/filter_list/load.cc b/generate/templates/manual/filter_list/load.cc
@@ -134,7 +134,7 @@ void GitFilterList::LoadWorker::HandleOKCallback() {
       // GitFilterList baton->filters
       v8::Local<v8::Array> owners = Nan::New<Array>(0);
       v8::Local<v8::Object> filterRegistry = Nan::New(GitFilterRegistry::persistentHandle);
-      v8::Local<v8::Array> propertyNames = filterRegistry->GetPropertyNames();
+      v8::Local<v8::Array> propertyNames = Nan::GetPropertyNames(filterRegistry).ToLocalChecked();
 
       Nan::Set(
         owners,
@@ -214,7 +214,7 @@ void GitFilterList::LoadWorker::HandleOKCallback() {
           break;
         }
 
-        v8::Local<v8::Array> properties = nodeObj->GetPropertyNames();
+        v8::Local<v8::Array> properties = Nan::GetPropertyNames(nodeObj).ToLocalChecked();
         for (unsigned int propIndex = 0; propIndex < properties->Length();
              ++propIndex) {
           v8::Local<v8::String> propName =
diff --git a/generate/templates/manual/revwalk/fast_walk.cc b/generate/templates/manual/revwalk/fast_walk.cc
@@ -144,7 +144,7 @@ void GitRevwalk::FastWalkWorker::HandleOKCallback()
           break;
         }
 
-        Local<v8::Array> properties = nodeObj->GetPropertyNames();
+        Local<v8::Array> properties = Nan::GetPropertyNames(nodeObj).ToLocalChecked();
         for (unsigned int propIndex = 0; propIndex < properties->Length(); ++propIndex)
         {
           Local<v8::String> propName = Nan::To<v8::String>(properties->Get(propIndex)).ToLocalChecked();
diff --git a/generate/templates/partials/async_function.cc b/generate/templates/partials/async_function.cc
@@ -217,7 +217,7 @@ void {{ cppClassName }}::{{ cppFunctionName }}Worker::HandleOKCallback() {
           break;
         }
 
-        v8::Local<v8::Array> properties = nodeObj->GetPropertyNames();
+        v8::Local<v8::Array> properties = Nan::GetPropertyNames(nodeObj).ToLocalChecked();
         for (unsigned int propIndex = 0; propIndex < properties->Length(); ++propIndex) {
           v8::Local<v8::String> propName = Nan::To<v8::String>(properties->Get(propIndex)).ToLocalChecked();
           v8::Local<v8::Value> nodeToQueue = nodeObj->Get(propName);

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ void GitClone::CloneWorker::HandleOKCallback() {`
`180`	`180`	`break;`
`181`	`181`	`}`
`182`	`182`
`183`		`- v8::Local<v8::Array> properties = nodeObj->GetPropertyNames();`
	`183`	`+ v8::Local<v8::Array> properties = Nan::GetPropertyNames(nodeObj).ToLocalChecked();`
`184`	`184`	`for (unsigned int propIndex = 0; propIndex < properties->Length();`
`185`	`185`	`++propIndex) {`
`186`	`186`	`v8::Local<v8::String> propName =`
Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ void GitRevwalk::FastWalkWorker::HandleOKCallback()`
`144`	`144`	`break;`
`145`	`145`	`}`
`146`	`146`
`147`		`- Local<v8::Array> properties = nodeObj->GetPropertyNames();`
	`147`	`+ Local<v8::Array> properties = Nan::GetPropertyNames(nodeObj).ToLocalChecked();`
`148`	`148`	`for (unsigned int propIndex = 0; propIndex < properties->Length(); ++propIndex)`
`149`	`149`	`{`
`150`	`150`	`Local<v8::String> propName = Nan::To<v8::String>(properties->Get(propIndex)).ToLocalChecked();`
Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ void {{ cppClassName }}::{{ cppFunctionName }}Worker::HandleOKCallback() {`
`217`	`217`	`break;`
`218`	`218`	`}`
`219`	`219`
`220`		`- v8::Local<v8::Array> properties = nodeObj->GetPropertyNames();`
	`220`	`+ v8::Local<v8::Array> properties = Nan::GetPropertyNames(nodeObj).ToLocalChecked();`
`221`	`221`	`for (unsigned int propIndex = 0; propIndex < properties->Length(); ++propIndex) {`
`222`	`222`	`v8::Local<v8::String> propName = Nan::To<v8::String>(properties->Get(propIndex)).ToLocalChecked();`
`223`	`223`	`v8::Local<v8::Value> nodeToQueue = nodeObj->Get(propName);`