remove FatalException

heavyk · heavyk · commit 3e69c59d1675 · 2015-06-21T21:09:48.000+02:00
The non-isolate version of node::FatalException() has been deprecated
in io.js; more precisely, it's deprecated in node.js v0.12 as well but
a bug in joyent/node prevents the deprecation warning from printing.

We don't have to catch exceptions ourselves.  Exceptions simply unwind
the stack until they encounter a try/catch block is encountered or the
fatal exception handler in the io.js or node.js run-time.
diff --git a/generate/templates/partials/async_function.cc b/generate/templates/partials/async_function.cc
@@ -103,8 +103,6 @@ void {{ cppClassName }}::{{ cppFunctionName }}Worker::Execute() {
 }
 
 void {{ cppClassName }}::{{ cppFunctionName }}Worker::HandleOKCallback() {
-  TryCatch try_catch;
-
   if (baton->error_code == GIT_OK) {
     {%if not .|returnsCount %}
     Handle<v8::Value> result = NanUndefined();
@@ -162,10 +160,6 @@ void {{ cppClassName }}::{{ cppFunctionName }}Worker::HandleOKCallback() {
     {%endeach%}
   }
 
-  if (try_catch.HasCaught()) {
-    node::FatalException(try_catch);
-  }
-
   {%each args|argsInfo as arg %}
     {%if arg.isCppClassStringOrArray %}
       {%if arg.freeFunctionName %}
