multiple code improvements: squid:S2293, squid:UnusedPrivateMethod, squid:S00122, squid:S1192 #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private void pauseOSC() { | ||
| pause(); | ||
| startButton.setText(isRunning() ? "Resume" : "Start"); | ||
| startButton.setText(isRunning() ? "Resume" : START); |
Member
There was a problem hiding this comment.
Here it's weird that "Resume" doesn't get refactored out into a static string as well.
Contributor
Author
There was a problem hiding this comment.
Hello Sir, "Resume" has single occurrence in the file, but if you prefer to have it refactored, I will do it.
Member
There was a problem hiding this comment.
I know, I assume that's why your tool picked it up. However here for consistency I would refactor it out as well.
…quid:S00122, squid:S1192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rules
squid:S2293 The diamond operator ("<>") should be used.
squid:UnusedPrivateMethod Unused private method should be removed.
squid:S00122 Statements should be on separate lines.
squid:S1192 String literals should not be duplicated.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS2293
https://dev.eclipse.org/sonar/coding_rules#q=squid%3AUnusedPrivateMethod
https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS00122
https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1192
Please let me know if you have any questions.
George Kankava