Skip to content

Line height controls for the text path node #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adiron wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Line height controls for the text path node #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96578ad
Line height can now be controlled via the UI
adiron Feb 6, 2016
8de27ca
Merge branch 'master' of https://github.com/nodebox/nodebox
adiron Feb 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libraries/corevector/corevector.ndbx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@
</port>
<port name="position" range="value" type="point" value="0.00,0.00" widget="point" description="The center point of the text."/>
<port min="0.0" name="width" range="value" type="float" value="0.0" widget="float" description="The maximum width of the text."/>
<port name="line_height" range="value" type="float" value="1.2" widget="float" description="The height of the line."/>
</node>
<node description="Move the shape, changing its position." function="pyvector/translate" handle="corevector/translateHandle" image="translate.png" name="translate" position="7.00,12.00" prototype="filter">
<port name="translate" range="value" type="point" value="0.00,0.00" widget="point" description="The amount of translation."/>
Expand Down
6 changes: 3 additions & 3 deletions libraries/corevector/pyvector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,10 +849,10 @@ def text_on_path(text, shape, font_name, font_size, alignment, margin, baseline_
p.add(contour)

return p
def textpath(text, font_name="Verdana", font_size=24, align="CENTER", position=Point.ZERO, width=0, height=0):

def textpath(text, font_name="Verdana", font_size=24, line_height=1.2, align="CENTER", position=Point.ZERO, width=0, height=0):
"""Create a path out of text."""
t = Text(unicode(text), position.x, position.y, width, height)
t = Text(unicode(text), position.x, position.y, width, height, line_height)
t.fontName = font_name
t.fontSize = font_size
# valueOf requires a correct value: LEFT, CENTER, RIGHT or JUSTIFY. Anything else will
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/nodebox/function/CoreVectorFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ public static List<Path> ungroup(IGeometry shape) {
*
* @return A new Path.
*/
public static Path textpath(String text, String fontName, double fontSize, String alignment, Point position, double width) {
public static Path textpath(String text, String fontName, double fontSize, String alignment, Point position, double width, double lineHeight) {
Text.Align align;
try {
align = Text.Align.valueOf(alignment);
Expand All @@ -573,6 +573,7 @@ public static Path textpath(String text, String fontName, double fontSize, Strin
t.setFontName(fontName);
t.setFontSize(fontSize);
t.setAlign(align);
t.setLineHeight(lineHeight);

return t.getPath();
}
Expand Down