Skip to content

Extend list of reserved IP addresses #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RubenVerborgh merged 1 commit into from
Sep 30, 2018
Merged

Extend list of reserved IP addresses #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions lib/handlers/cors-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,35 @@ const PROXY_SETTINGS = {
router: req => req.destination.target,
pathRewrite: (path, req) => req.destination.path
}
const LOCAL_IP_RANGES = [
'10.0.0.0/8',
'127.0.0.0/8',
'172.16.0.0/12',
'192.168.0.0/16'
// https://en.wikipedia.org/wiki/Reserved_IP_addresses
const RESERVED_IP_RANGES = [
'127.0.0.0/8', // loopback
'::1/128', // loopback
'0.0.0.0/8', // current network (only valid as source address)
'169.254.0.0/16', // link-local
'10.0.0.0/8', // private network
'100.64.0.0/10', // Shared Address Space
'172.16.0.0/12', // private network
'192.0.0.0/24', // IETF Protocol Assignments
'192.0.2.0/24', // TEST-NET-1, documentation and examples
'192.88.99.0/24', // IPv6 to IPv4 relay (includes 2002::/16)
'192.168.0.0/16', // private network
'198.18.0.0/15', // network benchmark tests
'198.51.100.0/24', // TEST-NET-2, documentation and examples
'203.0.113.0/24', // TEST-NET-3, documentation and examples
'224.0.0.0/4', // IP multicast (former Class D network)
'240.0.0.0/4', // reserved (former Class E network)
'255.255.255.255', // broadcast
'64:ff9b::/96', // IPv4/IPv6 translation (RFC 6052)
'100::/64', // discard prefix (RFC 6666)
'2001::/32', // Teredo tunneling
'2001:10::/28', // deprecated (previously ORCHID
'2001:20::/28', // ORCHIDv2
'2001:db8::/32', // documentation and example source code
'2002::/16', // 6to4
'fc00::/7', // unique local address
'fe80::/10', // link-local address
'ff00::/8' // multicast
]

// Adds a CORS proxy handler to the application on the given path
Expand Down Expand Up @@ -58,7 +82,7 @@ function extractProxyConfig (req, res, next) {
// Verifies and adds the proxy configuration to the request
function addProxyConfig (error, hostAddress) {
// Ensure the host is not a local IP
if (error || LOCAL_IP_RANGES.some(r => ipRange(hostAddress, r))) {
if (error || RESERVED_IP_RANGES.some(r => ipRange(hostAddress, r))) {
return res.status(400).send(`Cannot proxy ${uri}`)
}
req.destination = { path, target: `${protocol}//${host}` }
Expand Down
8 changes: 7 additions & 1 deletion test/integration/cors-proxy-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,13 @@ describe('CORS Proxy', () => {
.end(done)
})

const LOCAL_IPS = ['127.0.0.0', '10.0.0.0', '172.16.0.0', '192.168.0.0']
const LOCAL_IPS = [
'127.0.0.0',
'10.0.0.0',
'172.16.0.0',
'192.168.0.0',
'[::1]'
]
LOCAL_IPS.forEach(ip => {
it(`should return 400 for a ${ip} address`, (done) => {
nock(`https://${ip}`).get('/').reply(200)
Expand Down